Repository navigation
fix(bacnet): discover large object lists without segmentation - #2752
Open
RevanthMeda wants to merge 1 commit into
Open
RevanthMeda wants to merge 1 commit into
RevanthMeda wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1228.
BACnet devices without segmented-response support can abort a complete Object List read when the response exceeds one APDU. Discovery now retains the existing complete-list request first, then falls back to reading the array length and individual entries by array index.
Indexed reads are issued in bounded batches. Devices that support the original complete response continue using the existing single-request path.
Type
Artifacts
server/runtime/devices/bacnet/index.jsserver/test/devices/bacnetObjectList.test.jsc599ee8628cce829e29e05df4ef91c59f9d7e35dChecklist
Documentation
No user-facing documentation changes are required. The fallback is internal to BACnet object discovery.
Additional Notes
The full local suite had one environment-only failure:
uv_interface_addresses returned Unknown system error 1in the network-interface sandbox test. No physical BACnet hardware was available for validation.AI assistance was used to inspect the existing driver flow, construct the regression, and review the resulting patch; the behavior and test results were verified locally.