Fix broken test on builds relying on poco 1.12.x#126
Open
acmiyaguchi wants to merge 1 commit intofrankarobotics:developfrom
Open
Fix broken test on builds relying on poco 1.12.x#126acmiyaguchi wants to merge 1 commit intofrankarobotics:developfrom
acmiyaguchi wants to merge 1 commit intofrankarobotics:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run into build failures on arch when building libfranka via the ros-noetic-libfranka aur package. I get the following build failure.
This is because poco changed the
DatagramSocketconstructor (presumably in pocoproject/poco#3283, but I can't be sure because of intermittent github issues). The commit that made the breaking change is included in poco 1.12.x: pocoproject/poco@7852153In particular, the following change was made:
This PR resolves the issue by creating an empty socket and binding on it manually, which builds correctly on poco 1.12.1,