-
Notifications
You must be signed in to change notification settings - Fork 6
Improve how to get different types of DispatchInfo.target #118
Copy link
Copy link
Open
Enhancement
1 / 11 of 1 issue completed
Copy link
Labels
part:actorAffects the dispatching actorAffects the dispatching actorpriority:highAddress this as soon as possibleAddress this as soon as possiblescope:breaking-changeBreaking change, users will need to update their codeBreaking change, users will need to update their codestatus:blockedOther issues must be resolved before this can be worked onOther issues must be resolved before this can be worked ontype:enhancementNew feature or enhancement visitble to usersNew feature or enhancement visitble to users
Description
Metadata
Metadata
Assignees
Labels
part:actorAffects the dispatching actorAffects the dispatching actorpriority:highAddress this as soon as possibleAddress this as soon as possiblescope:breaking-changeBreaking change, users will need to update their codeBreaking change, users will need to update their codestatus:blockedOther issues must be resolved before this can be worked onOther issues must be resolved before this can be worked ontype:enhancementNew feature or enhancement visitble to usersNew feature or enhancement visitble to users
Type
Fields
Give feedbackNo fields configured for Enhancement.
What's needed?
It is difficult to use the current targets, defined as
TargetComponents = list[int] | list[ComponentCategory], because thematchstatement (andisinstance()can't deal with containers, so we can check that something is alistbut not that is alist[int]. We had issues in the past getting this right and we still do.Proposed solution
Wait until this is implemented in the client:
Dispatch.targetfrequenz-client-dispatch-python#139And then use the same solution here.
Use cases
No response
Alternatives and workarounds
No response
Additional context
This is mostly a reminder that we should update this library and the
DispatchInfoclass after frequenz-floss/frequenz-client-dispatch-python#139 is merged and released.