Fetch only ongoing dispatches#195
Merged
Marenz merged 1 commit intofrequenz-floss:v0.x.xfrom Sep 30, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR optimizes the dispatch fetching functionality by filtering out completed dispatches, fetching only ongoing ones to improve performance and relevance.
- Adds an
end_fromparameter to the dispatch client API call to filter out past dispatches - Updates tests to handle the new behavior where finished dispatches are filtered out
- Temporarily uses a development version of the frequenz-client-dispatch dependency
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| src/frequenz/dispatch/_bg_service.py | Adds time-based filtering to only fetch ongoing dispatches using end_from parameter |
| tests/test_frequenz_dispatch.py | Updates test expectations and adds logging to handle the new filtering behavior |
| pyproject.toml | Temporarily switches to development branch of frequenz-client-dispatch dependency |
| RELEASE_NOTES.md | Documents the new optimization feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
03a8d6a to
ea7fe7d
Compare
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Signed-off-by: Mathias L. Baumann <[email protected]>
llucax
reviewed
Sep 30, 2025
Contributor
llucax
left a comment
There was a problem hiding this comment.
Nice, LGTM, no approving only because of the PR dependency.
llucax
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on frequenz-floss/frequenz-client-dispatch-python#212