Miscelaneous improvements#16
Merged
leandro-lucarella-frequenz merged 9 commits intoApr 11, 2023
Merged
Conversation
For projects that have optional dependencies, our standard dev optional dependencies could cause clashes, or limit downstream projects. Using the `dev-` prefix makes it very clear that they are `dev` dependencies. Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
This makes it more clear which optional dependencies should be used for each session. Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
For now they are empty, but they are necessary to avoid the users getting a warning about non-existing optional depedencies. Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
This is actually the top-level package we are shipping, so we shouldn't be including files in the parent namespaces. Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
The top-level package is frequenz.repo.config so we import from there. It also makes the code more clear. Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
Look for pytest paths in the `pyproject.toml` file and add them to `extra_paths` automatically. Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
`pytest` was invoked with all source and extra paths, but it shouldn't. Instead the path should be configured by the user in pyproject.toml. If the user pass any positional arguments to the `pytest` sessions, then those arguments will be forwarded verbatim to `pytest`. Since `pytest` works with the default path `tests`, we leave that in the extra paths in case the user is not defining it explicitly in the configuration, but for more esoteric setups, the test paths should be automatically added. This commit also updates the default configuration for `api` to replace `tests` with `pytests` in the extra paths (even when the user should configure it explicitly, we want to remove `tests` as it might be for something else) and also to replace `src` with `py` in the source paths. Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
Split `nox` sections into a section for writing the `noxfile.py` and a section about configuring the `pyproject.toml` file. Signed-off-by: Leandro Lucarella <leandro.lucarella@frequenz.com>
leandro-lucarella-frequenz
added
part:docs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
noxsessions to make them more explicitnoxsessionspy.typedtofrequenz.repo.configflatten()really return an iteratorpytestpathspytestinvocation