Repository navigation
Preserve default environment bindings when the local workspace changes - #15
Merged
Merged
Conversation
friel-openai
added
the
codex-app-server
friel-openai
marked this pull request as ready for review
November 9, 2026 12:55
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
friel-openai
force-pushed
the
fix/preserve-turn-environment-bindings
branch
from
November 9, 2026 13:00
8c7a998 to
f40b57a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Thread.environmentsreports the selected IDs and workspaces but does not reportthat an optional default secondary failed startup. A client can copy that list
back to
turn/startwithout asking to change any remote binding. Treating theecho as a new selection makes the first turn fail the owner-configuration check.
Change
Keep an exact ordered echo of the current local-primary selection unchanged.
When the client changes only the primary local cwd or roots, update only that
workspace after rechecking the secondary bindings under the thread settings
lock. A changed secondary cwd, roots, or selection still goes through the
existing owner check. A secondary that failed startup remains unavailable.
Verification
The isolated app-server test passed with separate first turns for the full
environment echo, cwd-only input, and the projectless composer request. It also
checked the saved workspace list and rejected changes to the unavailable
secondary. Three existing selection and cwd controls passed in the same run.
That run's separate rejoin test failed and is not included in this change.
Independent public replay matched the candidate tree; the existing required-CI
selection is unchanged.
Codex Task:
codex://threads/01a029f4-9863-7523-be3e-864bebe4187a