Add support for PHP 8.4#332
Merged
localheinz merged 1 commit intofriendsoftwig:mainfrom Nov 27, 2024
cedric-anne:feature/php-8.4
Merged
Add support for PHP 8.4#332localheinz merged 1 commit intofriendsoftwig:mainfrom cedric-anne:feature/php-8.4
localheinz merged 1 commit intofriendsoftwig:mainfrom
cedric-anne:feature/php-8.4
Conversation
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
=========================================
Coverage 79.83% 79.83%
Complexity 749 749
=========================================
Files 55 55
Lines 2603 2603
=========================================
Hits 2078 2078
Misses 525 525 ☔ View full report in Codecov by Sentry. |
Ciloe
approved these changes
Jul 28, 2024
Contributor
Author
|
Hi, Is this possible to get this merged and released ? Not a big deal, but it pollutes our CI results. |
localheinz
approved these changes
Nov 27, 2024
Collaborator
|
Thank you, @cedric-anne! |
Collaborator
|
Released as |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implicitly nullable parameter declarations are deprecated in PHP 8.4. The proposed change is safe and is not considered by PHP as a signature change, see https://php.watch/versions/8.4/implicitly-marking-parameter-type-nullable-deprecated