Expose InnerResponse, Http properties#1291
Merged
Merged
Conversation
The current `FSharp.Data.WebResponse` wrapper does not allow the user to access the original response. In particular, the `WebResponse` will normally (always?) be a `HttpWebResponse`, which exposes critical properties like `StatusCode`, which are currently inaccessible save through parsing the added line in `Message`. This PR adds: - a set of properties that wrap those in [HttpWebResponse](https://docs.microsoft.com/it-it/dotnet/api/system.net.httpwebresponse?view=netframework-4.8), returning `None` if the wrapped response isn't a `HttpWebResponse` - an `InnerResponse` property that exposes the original `WebResponse`, for anything a user might need.
dsyme
requested changes
Oct 24, 2019
dsyme
left a comment
Contributor
There was a problem hiding this comment.
Looks great. Request adding comments. Adding a test wouldn't go astray either....
| override x.GetResponseStream () = responseStream :> Stream | ||
| member x.ResetResponseStream () = responseStream.Position <- 0L | ||
|
|
||
| member x.CharacterSet = httpProperty (fun r -> r.CharacterSet) |
Contributor
There was a problem hiding this comment.
Could you put a /// comment on each of these? I know these are missing on the rest but we may as well not make the problem worse :)
dsyme
approved these changes
Jan 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
FSharp.Data.WebResponsewrapper does not easily allow the user to access the original response.In particular, the
WebResponsewill normally (always?) be aHttpWebResponse, which exposes critical properties likeStatusCode, which are currently buried pretty deep under type tests (and I might not have found them at all without debugging and looking at the source):This PR adds to
FSharp.Data.WebResponse:a set of properties that wrap those in HttpWebResponse, returning
Noneif the wrapped response isn't aHttpWebResponsean
InnerResponseproperty that exposes the originalWebResponse, for anything else a user might need