Implementation and tests - non seekable multipart form files#1415
Merged
cartermp merged 3 commits intofsprojects:mainfrom Nov 25, 2021
Merged
Implementation and tests - non seekable multipart form files#1415cartermp merged 3 commits intofsprojects:mainfrom
cartermp merged 3 commits intofsprojects:mainfrom
Conversation
cartermp
reviewed
Nov 24, 2021
src/Net/Http.fs
Outdated
| override x.CanSeek = match length with | None -> false | Some _ -> true | ||
| override x.CanWrite = false | ||
| override x.Length with get () = length | ||
| override x.Length with get () = length |> Option.defaultWith (fun () -> NotSupportedException() |> raise) |
Collaborator
There was a problem hiding this comment.
What do you think about a more descriptive message like in Stream? https://docs.microsoft.com/en-us/dotnet/api/system.io.stream.length?view=net-6.0#exceptions
Contributor
Author
There was a problem hiding this comment.
If flipped on this a couple of times. But now rethinking, I reckon a simple failwith "One or more of the encompassed streams are not seekable and the length cannot be determined". We can probably do away with the NotSupportedException type as the CombinedStream is only internal to FSharp.data
cartermp
approved these changes
Nov 25, 2021
Collaborator
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Thank you! Will cut a release likely beginning of next week.
Collaborator
|
Should be live in NuGet promptly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer #1398