Proposed fix to #1420 on extra newline before endBoundaryStream#1421
Merged
cartermp merged 1 commit intofsprojects:mainfrom Jan 1, 2022
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in #1420 , two extra bytes of newline is appended to the last Multipart Item, this PR aims to fix it.
Since extra newline removed, two existing test cases shall be revised to reflect this change:
correct multipart content formatSeekable streams create Seekable CombinedStreamI have tested several scenarios on number of files, format, size etc. upon the built FSharp.Data.dll and looks good.