Merged
Conversation
Collaborator
|
@mlaily I merged the other one, could you rebase this please? |
mlaily
force-pushed
the
inline-schemas-docs
branch
from
6915392 to
c7412c8
Compare
Contributor
Author
|
@cartermp done. |
Contributor
Author
|
@cartermp but be careful not to merge this as-is: there is still a TODO to fix (replace a "version TBD" with the expected next version number) |
Collaborator
|
@mlaily there's a new version out - 4.2.10 - could you add that as appropriate here? (also I now realize this could have been a 4.3 release, ah well) |
- Fix some typos and formatting issues (notably, angle brackets need to be escaped or wrapped in back quotes for them not to be interpreted as html in the output) - Try to clarify when runtime errors occur with the providers - Document JSON comments support
mlaily
force-pushed
the
inline-schemas-docs
branch
from
c7412c8 to
90885f3
Compare
Contributor
Author
|
Ha, so much for semantic versioning! :D I replaced the version TBD with 4.2.10, updated the commit message, and rebased! Thank you for your work :) |
Collaborator
|
We live dangerously. |
cartermp
approved these changes
Aug 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a follow up PR for #1447, here is some documentation about the feature!
The branch is currently on top of the previous PR branch.
Please ignore all but the last two commits until the previous PR is merged and this one is rebased.
Note the TODO in the latest commit: I'm not sure which version will contain this new feature, so I left a
version TBDthat will have to be replaced before we merge the docs.