Merged
Conversation
Contributor
Author
|
I've manually tested that updating to the latest TPSDK with the workaround makes the packages usable. Then and editing It's not easy to automate this testing - our doc generation does consume the DLLs but not the packages we build. (Consuming built packages within the build itself is always surprisingly painful with .NET, as you have to use a local soure and make sure you're really getting the package version you built) |
Contributor
Author
|
Changed the version number to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues #1457 after #1459 caused revert #1460
Will require this workaround in the TypeProvider SDK fsprojects/FSharp.TypeProviders.SDK#388