Change the namespace of the public "InferenceMode" enum#1470
Merged
cartermp merged 2 commits intofsprojects:mainfrom Jan 7, 2023
Merged
Change the namespace of the public "InferenceMode" enum#1470cartermp merged 2 commits intofsprojects:mainfrom
cartermp merged 2 commits intofsprojects:mainfrom
Conversation
FSharp.Data.Runtime.StructuralInference should not have to be opened by end users just to initialize a type provider...
mlaily
force-pushed
the
fix-inferencemode-ns
branch
from
c9d9df1 to
ab2562a
Compare
cartermp
approved these changes
Jan 7, 2023
Collaborator
cartermp
left a comment
cartermp
left a comment
There was a problem hiding this comment.
Definitely fine with the change here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a breaking change, but I feel like it's needed...
Using
FSharp.Data.Runtime.StructuralInferencewas a mistake (sorry, my bad). It should not be necessary to reference that namespace just to initialize a type provider...I moved the enum to the
FSharp.Datanamespace instead, the same as the providers so it's readily available:opened to use the enum with a type provider.I have no idea how much this new-ish enum is used in the wild, but since it's optional and a bit obscure, it might not impact too many users...
Since the next version will be the new major version 6.x and it's still currently in beta, I think this is a good opportunity to do this kind of thing now.