Skip to content

[Repo Assist] eng: replace deprecated WebClient with HttpClient; bump Newtonsoft.Json and System.Memory#1144

Open
dsyme wants to merge 2 commits intomainfrom
repo-assist/eng-modernize-2026-04-04-f6831f863e5cfa40
Open

[Repo Assist] eng: replace deprecated WebClient with HttpClient; bump Newtonsoft.Json and System.Memory#1144
dsyme wants to merge 2 commits intomainfrom
repo-assist/eng-modernize-2026-04-04-f6831f863e5cfa40

Conversation

@dsyme
Copy link
Copy Markdown
Contributor

@dsyme dsyme commented Apr 4, 2026

…on and System.Memory

  • Replace System.Net.WebClient with System.Net.Http.HttpClient in createImageSaver (BuildCommand.fs). Removes #nowarn "44" suppression and uses GetByteArrayAsync/File.WriteAllBytes instead of the deprecated DownloadFile API.
  • Bump Newtonsoft.Json transitive-dep pin: 13.0.3 → 13.0.4
  • Bump System.Memory transitive-dep pin: 4.5.5 → 4.6.3

Build: succeeded (0 warnings, 0 errors)
Tests: all pass (281 Markdown, 30 CodeFormat, 12 fsdocs-tool, 143 Literate, 88 ApiDocs)

Before you go

Hi there! Thank you for your contribution to our project. To help maintain the quality of our codebase, our Continuous Integration (CI) system will automatically run several checks on your submission. To streamline the process, we kindly ask you to perform these checks locally before pushing your changes:

To execute all build scripts, please run:

dotnet fsi build.fsx

If you encounter any formatting issues, you can auto-correct them by running:

dotnet fantomas build.fsx src tests docs

Should any tests fail, please review and adjust your changes accordingly.

We appreciate your efforts to contribute and look forward to reviewing your pull request!

Please remove this placeholder from the PR description after reading it and replace it with a clear, meaningful description of the changes in this PR.

github-actions bot and others added 2 commits April 4, 2026 10:47
…on and System.Memory

- Replace System.Net.WebClient with System.Net.Http.HttpClient in
  createImageSaver (BuildCommand.fs). Removes #nowarn "44" suppression
  and uses GetByteArrayAsync/File.WriteAllBytes instead of the
  deprecated DownloadFile API.
- Bump Newtonsoft.Json transitive-dep pin: 13.0.3 → 13.0.4
- Bump System.Memory transitive-dep pin: 4.5.5 → 4.6.3

Build: succeeded (0 warnings, 0 errors)
Tests: all pass (281 Markdown, 30 CodeFormat, 12 fsdocs-tool, 143 Literate, 88 ApiDocs)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants