Add quickfix suggestions for several rules #649
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@webwarrior-ws can you review please? (especially the last 2 commits) |
src/FSharpLint.Core/Rules/Conventions/Binding/FavourIgnoreOverLetWild.fs
Outdated
Show resolved
Hide resolved
tests/FSharpLint.Core.Tests/Rules/Binding/FavourIgnoreOverLetWild.fs
Outdated
Show resolved
Hide resolved
src/FSharpLint.Core/Rules/Conventions/Binding/UselessBinding.fs
Outdated
Show resolved
Hide resolved
Mersho
force-pushed
the
ImplementQuickFixes
branch
4 times, most recently
from
1ceb155 to
570c9f3
Compare
Collaborator
|
Could you rebase and check? |
Collaborator
|
Could you rebase, please? |
Implement suggested fix for FavourConsistentThis rule.
Since I need let expression range, I had to remove the `isLetBinding`. Co-authored-by: webwarrior <[email protected]>
Co-authored-by: webwarrior <[email protected]>
Mersho
force-pushed
the
ImplementQuickFixes
branch
from
e7daa38 to
e20ee38
Compare
Mersho
force-pushed
the
ImplementQuickFixes
branch
from
e20ee38 to
bed28b2
Compare
Contributor
webwarrior-ws
left a comment
webwarrior-ws
left a comment
There was a problem hiding this comment.
That's a lot of changes. I didn't notice anything suspicious. So if the tests are green than likely nothing was broken during rebase.
Collaborator
|
Thanks Mershad. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add quickfix suggestions for following rules: