Fixed MSBuild integration sample in docs #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xperiandri
force-pushed
the
msbuild-task-manual-fix
branch
from
d04c48b to
460eaa3
Compare
Collaborator
Author
|
@baronfel should we add anything else? |
Contributor
|
That LGTM! |
Collaborator
This is just the what, but please don't forget to include the why in the commit msg. |
Without `'$(DesignTimeBuild)' != 'true'"`: - Visual Studio build never ends - `dotnet build` hangs the whole PC
xperiandri
force-pushed
the
msbuild-task-manual-fix
branch
from
460eaa3 to
5cc384d
Compare
Collaborator
Author
|
Excellent suggestion @knocte ! I've added that both here and in the commit description |
Collaborator
I was quoting the first commit msg. You didn't amend that one. |
xperiandri
added a commit
that referenced
this pull request
Jul 18, 2025
## [0.26.0] - 2025-07-18 - Fix MSBuild integration sample in docs #750 [@xperiandri] - Exit after printing out version information #743 [@Numpsy] - Fix .NET 8 support #748 [@xperiandri] - Update docs to note that linting supports `slnx` and `slnf` files #744 [@Numpsy]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #747
Without
'$(DesignTimeBuild)' != 'true'":dotnet buildhangs the whole PC