NestedFunctionNames,UnnestedFunctionNames: fix rules #759
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knocte
reviewed
Aug 6, 2025
tests/FSharpLint.Core.Tests/Rules/Conventions/Naming/UnnestedFunctionNames.fs
Outdated
Show resolved
Hide resolved
Specifically for NestedFunctionNames and UnnestedFunctionNames rules. Added test cases make sure the rule doesn't fire on bindings that are not functions.
Fix rules to only take into account function and method names.
webwarrior-ws
force-pushed
the
fix-rule-80-and-81
branch
from
2148bec to
0264277
Compare
Collaborator
|
Let's also add a test (for each rule) that has a function with no parameters (so, with the unit |
Contributor
Author
But we already have such tests. |
Collaborator
|
I just checked tests/FSharpLint.Core.Tests/Rules/Conventions/Naming/NestedFunctionNames.fs and all testcases with nested funcs have one param. |
Added a test for nested function with no parameters where the rule gives a positive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed rules to only take into account function and method names.
Added test cases make sure the rule doesn't fire on bindings that are not functions.