Makefile: don't skip 'docs' target#766
Merged
knocte merged 1 commit intofsprojects:masterfrom Nov 5, 2025
Merged
Conversation
Collaborator
|
Thanks @webwarrior-ws good catch. Maybe the better approach here is actually move the docs target to a Makefile inside the docs folder? Let's try that approach in a 2nd commit and I will decide what looks better. |
webwarrior-ws
force-pushed
the
ci-fix-docs
branch
2 times, most recently
from
82058f9 to
3fd5a69
Compare
knocte
reviewed
Aug 21, 2025
webwarrior-ws
force-pushed
the
ci-fix-docs
branch
2 times, most recently
from
eeef0ea to
40ead10
Compare
Closed
Contributor
Author
|
LGTM |
If there is a file or directory named the same as target
('docs' in this case) in current directory, Make treats that
target as a file target. Since the file (dir in this case)
already exists and has no dependencies (or its dependencies
are older), Make considered it "up to date" and skipped execution.
To avoid this, we now use a .PHONY target to tell Make that 'docs'
is not a real file.
Fixes fsprojects#768
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If there is a file or directory named the same as target
('docs' in this case) in current directory, Make treats that
target as a file target. Since the file (dir in this case)
already exists and has no dependencies (or its dependencies
are older), Make considered it "up to date" and skipped execution.
To avoid this, we now use a .PHONY target to tell Make that 'docs'
is not a real file.
Fixes #768