Skip to content

Conversation

@Thorium
Copy link
Member

@Thorium Thorium commented Nov 10, 2025

Fixes #776

@knocte
Copy link
Collaborator

knocte commented Nov 10, 2025

Thanks @Thorium good work! Just from a quick glance, can you:

  1. Fix CI build please. It's again failing in the SelfCheck step, those issue are easy to address IMO, ping me if you need help.
  2. Can you add some kind of warning when using this command line option? Because it's still recommended/preferable that users use their solutions or projects, rather than individual files, because this way FSharpLint can act on the typed tree (and discover more warnings than if it were running on an untyped one).

@Thorium
Copy link
Member Author

Thorium commented Nov 10, 2025

Will check. The 2 major use-cases I have:

  1. I have a group of fsx files in random directory structure to check. There is no project.
  2. I have installed .NET10 runtime to a computer and global.json missing from a project, so FSharpLint fails for System.Runtime v10 errors.

@knocte
Copy link
Collaborator

knocte commented Nov 10, 2025

I have a group of fsx files in random directory structure to check. There is no project.

Ah, maybe if the wildcard ends with .fsx then it should not show a warning, since fsx files are generally not in a project. But things like *.fs, *.fs?, *.fs*, foo.fs should give a warning.

@Thorium
Copy link
Member Author

Thorium commented Nov 10, 2025

I think the warning is still ok to show: The best practice is not work with big bunch of fsx files because the compiled F# is faster.

@knocte knocte merged commit 33ee73e into fsprojects:master Nov 10, 2025
6 checks passed
@knocte
Copy link
Collaborator

knocte commented Nov 10, 2025

Merged, you can already use this feature if you grab this pre-release version from nuget:
0.26.5--date20251110-0458.git-33ee73e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support wildcards

2 participants