support creation of zonal buckets using mkdir#769
Open
Mahalaxmibejugam wants to merge 4 commits intofsspec:mainfrom
Open
support creation of zonal buckets using mkdir#769Mahalaxmibejugam wants to merge 4 commits intofsspec:mainfrom
Mahalaxmibejugam wants to merge 4 commits intofsspec:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #769 +/- ##
==========================================
- Coverage 75.78% 75.16% -0.63%
==========================================
Files 19 14 -5
Lines 2924 2605 -319
==========================================
- Hits 2216 1958 -258
+ Misses 708 647 -61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
/gcbrun |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the mkdir method in ExtendedGcsFileSystem to add the support for creation of zonal buckets and enhances the readability.
Key Changes:
Support for zonal bucket creation:
Refactored mkdir Logic:
This is required when creating Zonal buckets to specify the parent region (e.g., us-central1) for the zone (e.g., us-central1-a).
Documentation:
Updated the mkdir docstring to clearly explain how to create Zonal buckets using the placement and location parameters.
Tests:
Added unit tests and integration tests to verify the zonal bucket creation and folder creation in zonal buckets.