Update ZonalFile write operations with byte count and location tracking#777
Merged
ankitaluthra1 merged 1 commit intofsspec:mainfrom Mar 12, 2026
Merged
Update ZonalFile write operations with byte count and location tracking#777ankitaluthra1 merged 1 commit intofsspec:mainfrom
ankitaluthra1 merged 1 commit intofsspec:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #777 +/- ##
==========================================
+ Coverage 75.08% 75.45% +0.37%
==========================================
Files 14 14
Lines 2625 2628 +3
==========================================
+ Hits 1971 1983 +12
+ Misses 654 645 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
/gcbrun |
ankitaluthra1
approved these changes
Mar 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates
ZonalFile.write()to properly return the number of bytes written and track the logical file position (self.loc).Why: Missing byte returns and static file pointers caused downstream tools like PyTorch to calculate
0-length chunks, corrupting saved checkpoint metadata.Changes
ZonalFile.write(): Now returnslen(data)and incrementsself.loc += len(data).test_zonal_file_write_successto assert correct byte returns and sequentiallocaccumulation.