feat: add a a read name filtering writer to the API#1037
Draft
nh13 wants to merge 3 commits into
Draft
Conversation
Builds a [[Writer]] of [[SamRecord]]s where all records for a given read name (e.g. pair, including any secondary and supplementary) are output to the writer. This is implemented via collecting the unique read names from records passed into `write()`, then upon closing, all records in the original BAM are examined and any records with a matching read name are written the provided writer.
nh13
force-pushed
the
nh13/readnamefilteringwriter
branch
from
35e1399 to
8556c55
Compare
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (64.86%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1037 +/- ##
==========================================
- Coverage 95.68% 95.52% -0.16%
==========================================
Files 126 127 +1
Lines 7410 7447 +37
Branches 500 519 +19
==========================================
+ Hits 7090 7114 +24
- Misses 320 333 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds a
[[Writer]]of[[SamRecord]]s where all records for a given read name (e.g. pair, including any secondary and supplementary) are output to the writer. This is implemented via collecting the unique read names from records passed intowrite(), then upon closing, all records in the original BAM are examined and any records with a matching read name are written the provided writer.