Merged
Conversation
Having a None selected track_id and trying to map it through the colormap caused the error. To avoid this, we create a new track id if the selected track id is None. We also update the selected track when we update the selected node. There is still a problem with not using our custom new label function when you press m, but this is a separate issue.
I only made this change in the TrackLabels class, in the functions I read while fixing this bug. It has caused problems in the past when people have custom time attrs.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
==========================================
- Coverage 89.47% 89.47% -0.01%
==========================================
Files 650 650
Lines 60148 60149 +1
==========================================
- Hits 53817 53816 -1
- Misses 6331 6333 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Change
Set the selected track in the TrackLabels layer when setting the selected node, so that we stop passing None through the colormap. Closes #83
Also created #84 for a remaining issue with getting a new label associated with a new track.
Checklist
Go through these things before merge. Actions should run automatically to test them, but for information on how to run locally, see CONTRIBUTING.md.