Skip to content

83 bug invalid integer dtype#85

Merged
cmalinmayor merged 3 commits intomainfrom
83-bug-invalid-integer-dtype
Jul 17, 2025
Merged

83 bug invalid integer dtype#85
cmalinmayor merged 3 commits intomainfrom
83-bug-invalid-integer-dtype

Conversation

@cmalinmayor
Copy link
Contributor

@cmalinmayor cmalinmayor commented Jul 17, 2025

Proposed Change

Set the selected track in the TrackLabels layer when setting the selected node, so that we stop passing None through the colormap. Closes #83

Also created #84 for a remaining issue with getting a new label associated with a new track.

Checklist

Go through these things before merge. Actions should run automatically to test them, but for information on how to run locally, see CONTRIBUTING.md.

  • I have added tests that prove that my feature works in various situations or tests the bugfix (if applicable).
  • I have checked that the tests pass and I maintained or improved test coverage (if applicable).
  • I have written docstrings and checked that they render correctly in the documentation build.

Having a None selected track_id and trying to map it through the colormap caused the error. To avoid this, we create a new track id if the selected track id is None. We also update the selected track when we update the selected node. There is still a problem with not using our custom new label function when you press m, but this is a separate issue.
I only made this change in the TrackLabels class, in the functions I read while fixing this bug. It has caused problems in the past when people have custom time attrs.
@cmalinmayor cmalinmayor requested a review from AnniekStok July 17, 2025 01:27
Copy link
Collaborator

@AnniekStok AnniekStok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! :)

@codecov-commenter
Copy link

codecov-commenter commented Jul 17, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 89.47%. Comparing base (b1d06cc) to head (a183c84).

Files with missing lines Patch % Lines
finn/track_data_views/views/layers/track_labels.py 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   89.47%   89.47%   -0.01%     
==========================================
  Files         650      650              
  Lines       60148    60149       +1     
==========================================
- Hits        53817    53816       -1     
- Misses       6331     6333       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cmalinmayor cmalinmayor merged commit bff6554 into main Jul 17, 2025
4 checks passed
@cmalinmayor cmalinmayor deleted the 83-bug-invalid-integer-dtype branch July 17, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Invalid integer data type 'O' on paint

3 participants