Fix amqp_exchange_factory on python 3#172
Merged
Merged
Conversation
mvdbeek
force-pushed
the
python_3_amqp_fix
branch
2 times, most recently
from
811971d to
42bc617
Compare
5 tasks
mvdbeek
force-pushed
the
python_3_amqp_fix
branch
from
42bc617 to
548e1cd
Compare
Member
Author
|
I have no clue why https://travis-ci.org/galaxyproject/pulsar/jobs/518409610#L816 is failing. I ran that one locally on python 3.6 (had catch the drmaa module import error on OSX, but I don't think that matters for this test) and it passes |
Member
Author
|
Cool, looks like the last commit fixed the test? |
Member
|
Thanks @mvdbeek! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.