Simplify etc/BuildPackages.sh #143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be sufficient to build all current package versions. It will *not* work for older versions of some packages.
Collaborator
|
This might be a horrible idea, but: Could we somehow detect how "new" the package is and choose either the new or old version as appropriate? It seems like the two versions cover every case, but is it hard to pick the right one? Could we detect failure and fall back to the other version? |
Member
Author
|
I think that would be worse than just keeping the script as it is :-). Overall I don't think merging this is beneficial for anyone |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be sufficient to build all current package versions.
It will not work for older versions of some packages.
As such I am not sure whether it is worth it to merge it. Or perhaps it should be merged but only after some more time passes. In any case, I thought I should get it out here as a possibility.