Allow loading of extraperfect files from all root dirs #5938
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 13, 2025
fingolfin
added
kind: enhancement
fingolfin
approved these changes
Feb 21, 2025
Member
|
@ThomasBreuer any objections to merging this? |
Contributor
|
I think that this proposal is fine for the moment. As soon as |
Member
|
Indeed, but that work will only be in GAP 4.15, while this patch can be backported for 4.14.1 :-) |
Member
|
Backported to |
fingolfin
added
backport-to-4.14-DONE-unused
fingolfin
added
the
release notes: not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former code for loading perf27.grp and perf33.grp tried to load them using
READ_GAP_ROOTwhich only checks the root directories inSyGapRootPathsaka the root paths that are known at GAP's startup e.g. via the-lflag.However, this won't check any root directories that were added later using
ExtendRootDirectories.This PR changes this to check all root directories in
GAPInfo.RootPaths. The motivation for this is in OSCAR, where we want the julia lazy artifact handler to do the downloading of these files on first access, but due to how julia loads OSCAR and GAP.jl, this seems to be only possible usingExtendRootDirectories. (x-ref oscar-system/Oscar.jl#4592)cc @fingolfin @ThomasBreuer