Skip to content

Merge two DimensionOfMatrixGroup methods #6212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThomasBreuer merged 1 commit into from
Feb 1, 2026
+3 −24
Merged

Merge two DimensionOfMatrixGroup methods #6212

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 3 additions & 24 deletions lib/grpmat.gi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,30 +82,9 @@ end );
##
#M DimensionOfMatrixGroup( <mat-grp> )
##
InstallMethod( DimensionOfMatrixGroup, "from generators",
[ IsMatrixGroup and HasGeneratorsOfGroup ],
function( grp )
if not IsEmpty( GeneratorsOfGroup( grp ) ) then
return NumberRows( GeneratorsOfGroup( grp )[1] );
else
TryNextMethod();
fi;
end );

InstallMethod( DimensionOfMatrixGroup, "from one",
[ IsMatrixGroup and HasOne ], 1,
grp -> NumberRows( One( grp ) ) );

# InstallOtherMethod( DimensionOfMatrixGroup,
# "from source of nice monomorphism",
# [ IsMatrixGroup and HasNiceMonomorphism ],
# grp -> DimensionOfMatrixGroup( Source( NiceMonomorphism( grp ) ) ) );
#T this was illegal,
#T since it assumes that the source is a different object than the
#T original group; if this fails then we run into an infinite recursion!

#T why not delegate to `Representative' instead of installing
#T different methods?
InstallMethod( DimensionOfMatrixGroup,
[ IsMatrixGroup ],
grp -> NumberRows( Representative( grp ) ) );


#############################################################################
Expand Down
Loading