Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... and add some generalizations.
Add
ConformalSymplecticGroup, essentially analogous to the implementation ofSymplecticGroup, that is,ConformalSymplecticGroupand a constructorConformalSymplecticGroupCons,ConformalSymplecticGroupCons,IsFullSubgroupGLRespectingBilinearFormUpToScalarsthat is set in the groups returned byConformalSymplecticGroup,\inmethod for a matrix and a group inIsFullSubgroupGLRespectingBilinearFormUpToScalars,In
ConformalSymplecticGroup,GeneralLinearGroup,SpecialLinearGroup, andSymplecticGroup, support a filter that determines the representation of the matrices constructed as generators of the groups and as matrices of the invariant forms. (Note thatConformalSymplecticGroupandSymplecticGroupcallGeneralLinearGroupandSpecialLinearGroup, respectively, forn = 2.) For that, an "experimental" global optionConstructingFilteris used. CurrentlyIsPlistRepis the default value,IsPlistRepMAtrixis another possible value. (Eventually we want to support such a filter also for the other classical groups.)Change the delegation between methods of
SymplecticGroup: Do not delegate from the variant where a finite field is given to the variant with given size of the field, but the other way round. This way, it will be possible to use elements fromStandardFiniteField( p, n )instead ofGF( p, n )in the matrices. (Eventually we want to change this also for the other classical groups.)Once we decide about the setup that we want for
ConformalSymplecticGroup, implementations for other conformal classical group can be added, and the relevant methods in the Forms package can be adjusted and extended accordingly.