Skip to content

Conversation

@nickytd
Copy link
Collaborator

@nickytd nickytd commented Oct 9, 2025

How to categorize this PR?
/kind cleanup
/area logging

What this PR does / why we need it:
This PR refactors the Fluent Bit output plugin codebase by renaming packages and files for better consistency and clarity. The main changes include renaming the pkg/valiplugin package to pkg/plugin, updating the command directory from cmd/fluent-bit-vali-plugin to cmd/fluent-bit-output-plugin, and standardizing interface names from Vali to OutputPlugin. This refactoring improves code organization and makes the plugin structure more generic and maintainable.

Code changes:

  • Renamed pkg/valiplugin package to pkg/plugin and updated all references
  • Renamed command directory from cmd/fluent-bit-vali-plugin to cmd/fluent-bit-output-plugin
  • Updated interface name from Vali to OutputPlugin throughout the codebase
  • Modified build targets in Makefile to use new naming conventions (e.g., out_vali.sooutput_plugin.so)
  • Updated Dockerfile to reflect new plugin binary names and paths
  • Refactored test directories from tests/valiplugin to tests/plugin
  • Updated copyright headers and REUSE configuration for renamed files
  • Removed unused NewValiClientDecoratorFunc type from client types

Additional context:
This is a structural refactoring that maintains the same functionality while improving code organization. The changes make the plugin more generic by removing Vali-specific naming conventions, which aligns with the goal of creating a more flexible output plugin architecture.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Refactored Fluent Bit output plugin package structure by renaming pkg/valiplugin to pkg/plugin and updating related directories and interfaces for better code organization
  • 🔄 Regenerate Summary

@gardener-robot gardener-robot added the area/logging Logging related label Oct 9, 2025
@gardener-robot
Copy link

@nickytd Label kind/todo does not exist.

@gardener-robot gardener-robot added needs/review Needs review size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 9, 2025
@gardener-robot
Copy link

@hyperspace-insights[bot] Command /add is not available to you but only to a Maintainer, Member, Author.

1 similar comment
@gardener-robot
Copy link

@hyperspace-insights[bot] Command /add is not available to you but only to a Maintainer, Member, Author.

@gardener-robot
Copy link

@hyperspace-insights[bot] You have mentioned internal references in the public. Please check.

@gardener-robot gardener-robot added the kind/cleanup Something that is not needed anymore and can be cleaned up label Oct 9, 2025
@gardener-robot
Copy link

@nickytd You have mentioned internal references in the public. Please check.

@gardener-robot
Copy link

@hyperspace-insights[bot] Command /add is not available to you but only to a Maintainer, Member, Author.

1 similar comment
@gardener-robot
Copy link

@hyperspace-insights[bot] Command /add is not available to you but only to a Maintainer, Member, Author.

@nickytd nickytd self-assigned this Oct 9, 2025
@nickytd nickytd requested review from dnaeon and rrhubenov October 9, 2025 12:01
@gardener-robot
Copy link

@rrhubenov, @dnaeon You have pull request review open invite, please check

Copy link
Member

@rrhubenov rrhubenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 12, 2025
@nickytd nickytd merged commit de6961a into master Oct 13, 2025
56 checks passed
@nickytd nickytd deleted the refactor-plugin-name branch October 13, 2025 11:49
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/logging Logging related kind/cleanup Something that is not needed anymore and can be cleaned up reviewed/lgtm Has approval for merging size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants