Skip to content

Conversation

@nickytd
Copy link
Collaborator

@nickytd nickytd commented Nov 12, 2025

How to categorize this PR?
/kind enhancement
/area logging

What this PR does / why we need it:
This PR restores proxy configuration support for the Vali client in the fluent-bit output plugin. The changes enable users to configure HTTP proxy settings for the Vali client through the ProxyUrl configuration parameter, allowing the plugin to work in environments where direct internet access is restricted and proxy servers are required.

Code changes:

  • Added ProxyUrl to the list of extractable configuration keys in the fluent-bit output plugin
  • Implemented processProxyURLConfig function to parse and validate proxy URL configuration
  • Added proxy URL processing to the configuration post-processing pipeline
  • Enhanced configuration dumping to include proxy URL information for debugging
  • Updated test cases to verify proxy URL configuration parsing and validation

Additional context:
The proxy configuration follows the same pattern as the main URL configuration, supporting both ProxyURL and ProxyUrl parameter variants for flexibility. The implementation includes proper URL validation and error handling to ensure robust configuration parsing.

Which issue(s) this PR fixes:

Special notes for your reviewer:
This change maintains backward compatibility as the proxy configuration is optional. The implementation reuses standard Go net/url parsing for consistency and reliability.

Release note:

Added proxy configuration support for Vali client through ProxyUrl parameter
  • 🔄 Regenerate and Update Summary

@gardener-robot gardener-robot added needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 12, 2025
@gardener-robot
Copy link

@hyperspace-insights[bot] Command /add is not available to you but only to a Maintainer, Member, Author.

1 similar comment
@gardener-robot
Copy link

@hyperspace-insights[bot] Command /add is not available to you but only to a Maintainer, Member, Author.

@nickytd nickytd self-assigned this Nov 12, 2025
@nickytd
Copy link
Collaborator Author

nickytd commented Nov 12, 2025

@MichaelEischer, here it is.

@nickytd nickytd merged commit ecad522 into master Nov 13, 2025
58 checks passed
@nickytd nickytd deleted the bring-back-proxy-url branch November 13, 2025 11:01
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Nov 13, 2025
@MichaelEischer
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs/review Needs review size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/closed Issue is closed (either delivered or triaged)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants