Repository navigation
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
|
/trunk merge |
|
An error occurred while submitting your PR to the queue: |
|
Thank you for this, @fedster99, and for the work that went into it. We reviewed it against current main and decided not to take it: A mandatory long handoff costs tokens on every ship, and a no-waiver screenshot gate would block headless and spawned ships; a shorter optional summary could be considered later. Closing it with thanks; if the underlying problem still bites you, an issue describing it is very welcome. |
Summary
Ship workflow
/shipcompletion report self-contained: it now opens withWhat this work was about, naming the product or feature, prior behavior, motivating problem, and intended outcome before the engineering summary.Put simplyexplanation to name its concrete subject instead of depending on context-free pronouns.Installer runtime packaging
lib/directory besidebin/for agent sidecars, Codex, Factory, OpenCode, and Kiro, so command scripts can resolve their existing relative imports.Test Coverage
All changed behavior is regression-covered across the source template, generated artifacts, golden host fixtures, and all five affected install paths.
Pre-Landing Review
No issues found.
Design Review
No frontend files changed — design review skipped.
Eval Results
The diff selector chose the ship and journey behavior evals. The detached run completed with 46 passed, 318 skipped, and 21 environment failures: the Anthropic SDK has no API credential, Gemini exhausted its quota, and this machine has only Command Line Tools rather than full Xcode/XCTest. The selected agent runs therefore returned
error_apior provider-quota errors instead of behavioral verdicts; deterministic prompt-contract tests passed.Scope Drift
Scope Check: CLEAN. The branch contains the intended ship-handoff contract and the pending installer runtime-completeness fix, plus their tests and generated artifacts.
Plan Completion
No plan file detected.
TODOS
No TODO items completed in this PR.
Documentation
CHANGELOG.mdwith the user-facing handoff and installer behavior.Test plan
npx --yes bun@latest test test/ship-completion-report.test.ts test/host-config.test.ts test/gen-skill-docs.test.tsnpx --yes bun@latest run testnpx --yes bun@latest run buildnpx --yes bun@latest run scripts/gen-skill-docs.ts --dry-run --host allgit diff --check origin/main🤖 Generated with Codex