Repository navigation
fix: Windows build and ACL issues - #2452
Closed
chiragborse1 wants to merge 1 commit into
Closed
chiragborse1 wants to merge 1 commit into
chiragborse1 wants to merge 1 commit into
Conversation
- browse/scripts/build-node-server.sh: convert MSYS paths to Windows-style via cygpath -m so Bun can compile server-node.mjs - browse/src/file-permissions.ts: use %USERDOMAIN%\%USERNAME% (fallback to SID) instead of bare username to avoid granting machine SID when hostname equals username Fixes: * 'FileNot able to build browse/server-node.mjs on Windows (FileNotFound opening root directory) Browse server fails with EPERM on .gstack directory due to mistaken ACL granting machine SID
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
4 of 9 tasks
Owner
|
Thank you — this was absorbed on main (credited in the v1.6x CHANGELOG entries; roster in PR #2604). Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two Windows-specific issues that prevented gstack from working out-of-the-box:
Build failure for browse/server-node.mjs
/c/...absolute paths.cygpath -mwhen running under MINGW/MSYS/CYGWIN.ACL lockout on .gstack directory
chirag) for icacls grants.CHIRAG, userchirag), the bare name resolves to the machine SID instead of the user SID.%USERDOMAIN%\%USERNAME%(with fallback to the SID viawhoami /user) so the correct user gets access.After applying these patches:
.gstackdirectory is created with the correctCHIRAG\chirag:(OI)(CI)(F)ACL.browse goto https://example.com→ text extraction).browse.exeand the Node.js compatibility bundle (server-node.mjs) are built and functional.Tested on:
Fixes:
Related to: #997 (the codesign note is unrelated, but same class of Windows-specific issues)