Repository navigation
fix: Ubuntu 26.04 Playwright override is architecture-aware (#2916) - #2961
Closed
SomSamantray wants to merge 1 commit into
Closed
SomSamantray wants to merge 1 commit into
SomSamantray wants to merge 1 commit into
Conversation
…#2916) The Ubuntu 26.04 Chromium platform override added for garrytan#2101 unconditionally set PLAYWRIGHT_HOST_PLATFORM_OVERRIDE=ubuntu24.04-x64, with no architecture check. On an arm64 Ubuntu 26.04 host this downloaded an x86-64 Chromium headless-shell build, which then failed with "exec format error" — a failure the later launch-diagnostic misreported as an AppArmor sandbox problem, sending users down the wrong debugging path entirely. Make the override pick the matching ubuntu24.04 build per uname -m (aarch64/arm64 -> ubuntu24.04-arm64, else ubuntu24.04-x64), which Playwright publishes and which the issue reporter verified works. Adds a targeted test (test/setup-playwright-best-effort.test.ts) that runs the real detection `if` from setup with _os_id/_os_ver pre-set and uname stubbed, covering aarch64, arm64, and x86_64 on the 26.04 path, plus a 24.04 regression guard that the override stays untouched off that path. A static invariant pins the case-statement shape so it can't silently flatten back to unconditional x64. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
Contributor
Author
Contributor
|
Thanks for this, @SomSamantray. The fix is now on main: setup's Ubuntu 26.04 Playwright override picks ubuntu24.04-x64 or -arm64 by architecture (setup:1669-1673) (fixed in v1.91.2.0, #2959). Closing as superseded; if you still see the problem on the latest gstack, please open an issue with ./setup --status output. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
On an arm64 Ubuntu 26.04 host,
./setupdownloads an x86-64 Chromiumheadless-shell build because the Ubuntu-26.04 Playwright platform override
(added for #2101) hardcodes
ubuntu24.04-x64with no architecture check. Thebinary then fails with
exec format error, which the later launch-failurediagnostic misreports as an AppArmor sandbox problem — sending users down the
wrong debugging path entirely. This change makes the override pick the
architecture-matching build (
ubuntu24.04-arm64on aarch64/arm64, unchangedubuntu24.04-x64everywhere else), fixing browser-dependent skills (/qa,/design-review,/browse, make-pdf,/pair-agent) on arm64 Ubuntu 26.04.Fixes #2916.
Live evidence
The 4 new tests run the real detection
ifsliced straight out ofsetup(not a reimplementation) with_os_id/_os_verpre-set andunamestubbed, proving the branch itself:
Plus a static invariant pinning the case-statement shape so a future edit
can't silently flatten it back to unconditional x64:
Scope
setup(the Ubuntu-26.04 override, now arch-aware via acase "$(uname -m)") andtest/setup-playwright-best-effort.test.ts(4new tests + 1 static invariant covering the fix).
(
bun test test/setup-playwright-best-effort.test.ts, 39/39 pass) and abash -n setupsyntax check, both shown above.have one) — verification is at the shell-logic level: the exact detection
code from
setupexecuted with_os_id=ubuntu,_os_ver=26.04, anduname -mstubbed to each real-world value, asserting the exact overridestring Playwright expects. No shellcheck run locally (not installed on
this machine); CI's
quality-gateworkflow covers it.Liveness proof (required for external contributors)
Screenshot of
GSTACK PRtyped live into a real Terminal prompt — attachedas a comment on this PR immediately after opening it.
Checklist
GSTACK PRtyped live into a real surface) — see comment on this PR