Repository navigation
v1.91.166.0 test: warm PowerShell 5.1 outside the setup-ps1 legacy cases; xvfb round trip on a private display range (GSTA-57) - #3324
Merged
Conversation
…trip uses a private display range (GSTA-57) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
…-load Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
…ses; xvfb round trip on a private display range (GSTA-57) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily flaky-fix pass (GSTA-57), group 6: free and load-sensitive tests. These are two timing and isolation repairs. No test timeout, case or assertion was loosened.
test/setup-ps1.test.ts, PowerShell 5.1 legacy cases ("space in TMPDIR", "empty argument refused"; windows-setup on 2026-10-17 job 117591782811, and run 39351736921 attempt 1, job 118397262881).windows-setup-e2e.ymlruns the file with plainbun test, so each case gets Bun's 5 s default. The firstpowershell.exelaunch on a runner pays a cold start that later launches don't. Across 94 windows-setup jobs:A
beforeAllnow runs the legacy interpreter once on the stub checkout, with a 60 s hook budget that matches the spawns' own 60 s bound. To reproduce it on Linux, I used pwsh 7.4.6 in Legacy mode under plainbun test:The file triggers the windows-setup workflow, so this PR's CI exercises real PS 5.1.
browse/test/xvfb.test.ts, spawn → cleanup round trip (Ubicloud full run, 2026-10-18). The test picked a display from:99-:110and then spawned on it, inside the default range that headed daemons in parallel shards allocate from. With six default-range allocators running, main failed 9/20 and 5/20 with "X display :N was reserved by another X server during startup". The case now uses:25000-:25100, which no other allocator uses, the same convention as the file's other private-range cases. If no display is free it now fails instead of silently returning. Under the same load it passed 20/20, 20/20 and 10/10. The ownership, lock and refusal assertions are unchanged.Diagnosed and left open, with no edits here:
test/gstack-doctor.test.ts, the Windows CSO row. This is a 30 s budget fitting four full doctor runs (39 passes took 14.5–28.4 s), not a flake. Open PR v1.91.138.0 feat(eval-plan): cli-run stops a subscription eval at the first quota error #3273 touches that file.Checks:
test/setup-ps1.test.tsandbrowse/test/xvfb.test.tspass (37 pass, 34 skip on Linux).typecheck, thetypecheck:testratchet, the module-size ratchet and the spawnSync tripwire pass. No paid cases are affected.