Skip to content

feat: inline /office-hours — no more "another window" (v0.11.3.1) - #352

Merged
garrytan merged 4 commits into
mainfrom
garrytan/office-hours-in-same-context-please
Mar 23, 2026
Merged

garrytan merged 4 commits into
mainfrom
garrytan/office-hours-in-same-context-please

Conversation

@garrytan

Copy link
Copy Markdown
Owner

Summary

  • When /plan-ceo-review or /plan-eng-review detect no design doc and offer to run /office-hours, it now runs inline in the same conversation instead of telling the user to open another window
  • Uses the read-and-follow pattern (same as /autoplan uses to chain review skills) — battle-tested, no Skill tool nesting risk
  • Removes handoff note save infrastructure from plan-ceo-review template (handoff note check kept for backward compat)
  • Mid-session detection ("still figuring out what to build?") also updated to inline invocation

Changes

File Change
scripts/gen-skill-docs.ts generateBenefitsFrom() — read-and-follow invocation + 7-section skip list
plan-ceo-review/SKILL.md.tmpl Remove handoff note saves, update mid-session to inline
test/gen-skill-docs.test.ts Negative ("another window" absent) + positive ("office-hours/SKILL.md" present) assertions
Generated SKILL.md files Regenerated via bun run gen:skill-docs

Test Coverage

  • bun test passes (exit code 0)
  • Zero "another window" references across all generated SKILL.md files
  • Read-and-follow path (office-hours/SKILL.md) confirmed present in generated output

Pre-Landing Review

No issues found. Prompt-template-only change — no application code paths, no security surface, no performance impact.

Test plan

  • bun test passes
  • Grep verification: zero "another window" in any SKILL.md
  • Positive verification: "office-hours/SKILL.md" path in CEO and eng review output
  • Manual test: invoke /plan-ceo-review on a branch with no design doc, pick A, verify /office-hours runs inline

🤖 Generated with Claude Code

garrytan and others added 4 commits March 22, 2026 20:51
BENEFITS_FROM now uses read-and-follow pattern (same as /autoplan) to run
/office-hours inline. Removes handoff note save infrastructure from
plan-ceo-review template. Keeps handoff note check for backward compat.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
VERSION and CHANGELOG conflicts resolved: our inline office-hours
feature rebased on top of main's v0.11.4.0 (Codex in Office Hours).
VERSION and CHANGELOG conflicts resolved: our inline office-hours
feature rebased on top of main's v0.11.5.0 (Bash Compatibility Fix).
@garrytan
garrytan merged commit 9eb74de into main Mar 23, 2026
rapidstartup pushed a commit to rapidstartup/gstack that referenced this pull request Mar 29, 2026
…rrytan#352)

* feat: inline /office-hours invocation — no more "another window"

BENEFITS_FROM now uses read-and-follow pattern (same as /autoplan) to run
/office-hours inline. Removes handoff note save infrastructure from
plan-ceo-review template. Keeps handoff note check for backward compat.

* chore: bump version and changelog (v0.11.3.1)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
capy-ai Bot added a commit that referenced this pull request Nov 19, 2026
…arge data PRs (GST-3158) (#4511)

A repo can now list published-data folders under a new
`review_content_patterns` ship-policy key, so /ship leaves `.patch`
diffs, `MANIFEST.sha256` and extension-less licences out of review,
while source files there stay reviewed.

Why: gstack-evals #352 is 13.8 MB, 13.6 MB of it published session data,
and could never pass /ship's 2 MB review limit.

Nothing to do until a repo adds the key to its base-branch policy; a
pattern that keeps too many files now stops with
`REVIEW_EXCLUDE_KEEP_TOO_LARGE` instead of being dropped.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/red-team#2 reader=red-team
Review-Finding: p2full/red-team#1 reader=red-team
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant