Repository navigation
v1.92.31.0 fix(flaky): qa-callers child handoff and three ship-docsync detector gaps (2026-10-29 flaky pass, GSTA-162) - #3606
Conversation
…hs; Step 9 gate scan joins diff discovery Nine paid ship qa-callers reds after #3553 (late-input, plan-checks, small-cli) had two causes, replayed from their retained captures (2026-10-29 flaky pass, GSTA-162): - six trials: the parent paraphrased its specialist prompt and the child ran the one refused call (git -C <dir> diff, or a cd into the checklist directory); - three late-input trials hit error_max_turns at 25/25 after running Step 9's gate scan only after the receipt, or never. The session prompt now tells the parent the child starts in the product directory, to write each command exactly as it must run and each Read as one literal path; the ship scheduling contract lists Step 9's review-plan command and gate-scan block with the first diff discovery. The detector is unchanged. Seven new replay tests fail with the fixture prompt stashed. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…e's wrong-path 127 and a full read before a failed separator; only the accepted docs attempt is parsed strictly Replayed from the 2026-10-29 window's ship-docsync reds (GSTA-162): - current 40822033640, completion 40815828320, store 40809051510: the parent joined `cat <candidate> --help 2>&1 | head -N` onto a line of reads; GNU cat printed its usage and read nothing. A declared read command given --help is neutral; its operands are still checked. - stale-after 40749421675: the cap gate typed at the shard root exited 127, then ran at the declared path. The wrong-path 127 excuse now covers the cap gate as well as the candidate. - failure 40828580338: phase.md printed in full, then zsh failed the `echo ======` separator. The read counts when the line's first unpiped cat printed the whole file first. - completion 40805543956: the parent rejected attempt 1 (no documentation_section) and re-audited; the case now parses only the accepted attempt strictly. Four public fixtures, registered as free fixtures. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ow to its moved lines Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
E2E Evals: ✅ PASS76 executed, 0 reused rule/judge records | 0 manual accepted (unscored; no score-cache credit) | $18.08 rule/judge cost | reconcile exit: 0 Profile: pr / mode Rule and judge shards
Fail-closed reconciliationSliced lane: planner → duration-packed executors → fail-closed report. Behavior cases run a pre-registered 3-trial panel (PASS at 2/3 with no contract violation); a PASS 2/3 is shown with its failed trial, never as a clean pass. Reused results retain their original provenance and expiry. Dispatched narrow screen (gstack-ship-queue ready --screen) of merge commit |
…-callers Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
…ock carry (GST-343, #3606) (#3706) * ship-receipt: carry demotes a metadata glob only for the branch's own changes (GST-343, #3606) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * ship-receipt: carry demotes a metadata glob from the branch's own non-stamp changes on either side (GST-343, GST-407 cycle 5 test) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * ship-receipt: a branch side that leaves a metadata path unchanged never demotes its glob Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
What changed
The 2026-10-29 paid flake captures replayed through the free tests: 10 fail with main's fixture prompt and detectors, 0 on this branch (run ids shortened to their last four digits for the image).
Before/after as text: The 2026-10-29 paid flake captures replayed through the free tests: 10 fail with main's fixture prompt and detectors, 0 on this branch
Why
Nine paid gate reds since #3553 (ship-exploratory-late-input, plan-checks, small-cli) and seven ship-docsync reds kept costing in-run reruns and blocking screens, and late-input was the top repeat in the ledger. Each red was replayed from its retained capture. The qa-callers trials failed because the parent handed its child a paraphrased boundary ("in
",cd,git -C) or ran Step 9's gate scan out of order, and the docsync trials failed on harmless calls the detector could not tell from a violation. Those correct runs now pass, and the real violations in the same captures are still refused.Blast radius
Test harness only: one fixture prompt (
test/helpers/qa-callers-fixture.ts), two docsync helpers, new replay fixtures and tests, one docs line re-pin. No skill prose, product code or CI config changes, so shipped behavior is unchanged. Every widened acceptance is pinned to its captured call with negative controls (redirects, pipes into the read, chained mutations,cd, wrong subcommands, a helper at the wrong path, truncated or errored reads). Evidence rung: the replay tests fail with main's helpers (10 fail) and pass here, and each repaired case passed a focused paid rerun.Approvals
Source: gstack-approvals record for capy/gsta162-flaky-qa-callers (display only; not an approval citation).
Summary
cdorgit -C), and that each file the child reads is one literal path. The ship scheduling contract lists Step 9's review-plan command and gate-scan block with the first diff discovery; three late-input trials spent 25 of 25 turns after running the gate scan late or never. The detector is unchanged.--helpis a read that reads nothing, with its operands still checked. The wrong-path exit-127 excuse covers the docs cap gate. A line whose first unpipedcatprinted the whole phase file still reads it when a later separator failed under zsh.Covered, not repaired: the late-input false green on #3567's screen listed Step 11's native reviewer as remaining work on a tree without #3553, which settled exactly that. Two completion reds (on #3553's and #3594's screens) are correct refusals: a forbidden stdout redirect and an undeclared program.
Test Coverage
New replay rows in existing owner tests:
test/qa-caller-review-plan.test.ts(7 new cases, one per captured child call plus the max-turns schedule),test/docsync-command-grammar.test.ts,test/docsync-lifecycle-interface.test.ts,test/docsync-authority.test.ts,test/ship-document-release-dispatch.test.ts. Five new public fixtures, registered intest/helpers/free-fixtures-data.ts. Failing-first: with main's three helpers, 10 of 250 fail; on this branch 250/250.Pre-Landing Review
REVIEW_LOOP: passes=1 blocking_found=0 deferred=0 noted=0 fixed=0 scope=frozen
Carried from 49666bc under CREW rule 30(b): the merge of main (48599bb) left the product patch-id against main at c8f281d8, the one this pass reviewed, and every changed line of the branch diff is identical.
gstack-ship-receipt carryrefused (RECEIPT_CARRY_PRODUCT_CHANGED) only because moving the [Unreleased] text out of CHANGELOG.md counts as a product change on the reviewed side, so the receipt was rewritten at the new head instead.Light depth (class tests): one core pass, clean, 0 findings. Outside voice: openai/gpt-6.1-sol (cross-family) on the full diff, NO FINDINGS. Specialists, Red Team and the native adversarial pass were not dispatched by the review plan.
Gate edits: none detected (24 listed, 10 read; patterns: RH-1,RH-3,RH-4,RH-12,RH-13,RH-14,RH-15,RH-16; unlisted idioms: none). The CHANGELOG's Gate integrity section names the three detector acceptances and the attempt-parsing change, because they widen what a paid case accepts.
Exploratory QA
Verdict pass, two captures (the replay suite, then the docsync negative controls), no open items.
Eval Results
Focused paid reruns at f798748, one each, after its free failing-first test: ship-exploratory-late-input PASS 1/1 ($1.18), plan-checks PASS 1/1 ($1.06), small-cli PASS 1/1 ($1.08), ship-docsync-current 1/1 ($0.85), -failure 1/1 ($0.52), -completion 1/1 ($1.11), -stale-after 1/1 ($0.41), -store 1/1 ($0.93). Total $7.14 against the $10 lane cap.
Issues
Refs #3553
Documentation
Status: updated (one factual line re-pin, no blockers)
Scope: base 48599bb (main) to HEAD e28bb62 on capy/gsta162-flaky-qa-callers, 17 files (test helpers, tests, new replay fixtures, one docs line and the changelog fragment); no staged, unstaged or untracked content. Test-only change: qa-callers fixture prompt, ship-docsync detectors, and parsing for rejected docs attempts. The merge of main touched none of this PR's files except
test/helpers/free-fixtures-data.ts, which merged cleanly; the detector-inventory pins (:85, :105) still match.Documentation health:
Documentation debt:
Coverage: no new public surface (test-only change). Diagram drift: none.
Test plan
UBI_OWNER=gsta162 gstack-pregate --stage tests --remote --spend-cap 2 --timeout 2700 --allow-repo-commands --base main(Ubicloud eu-central-h1): PREGATE_REMOTE tree=926633866d29 tests=4986 failed=0, $0.05.bun run typecheck: 0 errors;bun run typecheck:test: none new;bun run gen:skill-docs: no diff.test/qa-caller-review-plan.test.ts, threetest/docsync-*.test.ts,test/ship-document-release-dispatch.test.ts,test/free-fixtures.test.ts,test/module-size-ratchet.test.ts,test/spawnsync-timeout-tripwire.test.ts): 347 pass, 0 fail. Failing-first on the merged tree with main's three helpers: 11 of 251 fail.🤖 Generated with Claude Code