Repository navigation
v1.91.350.0 feat(review): GSTA-167 variant G reviewer stack: blocking floor in both voices, one batched specialist, data-file classifier - #3660
Merged
Conversation
…classifyDiff, untested state-matrix cells map below the floor per cell (GSTA-167 PR-a) Part 4a: lib/review-depth.ts owns DATA_PATH (JSON, JSONL, NDJSON, CSV, TSV, raster images; YAML, TOML and SVG stay code) and applies the data rule only in classifyDiff, to candidates lib/review-collect.ts finds no non-docs consumer for (git grep of basenames at head, merge base and, live, the working tree; data-to-data chains four deep; over 2,000 candidates keeps all code; a grep failure fails closed). classifyPath and every path-only caller are unchanged; the receipt gate scan decides through gateScanNeeded (path-only), so it cannot be skipped. gstack-ship-preflight computes RUNTIME_LINES with classifyDiff over gstack-review-plan --json (now with consumed). Part 4b: lib/review-scope.ts mapStateMatrixOutput maps an "untested cell" finding to INFORMATIONAL when its cell has test null in the same output's matrix and it is the only finding on that cell; gstack-state-matrix findings prints it for Step 9.2 before the merge. state-machines.md is byte-identical; check still reads the raw output. Reviewer-brief pins repinned under no-loss replay PR-a (Arm 4: plan identity at the 14 cohort heads; free exact re-score of saved C, D and A' findings). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…oices, specialists at medium (GSTA-167)
Part 1: the native adversarial and outside-voice prompts end with the blocking
floor ("would fail a test, break production, or lose data or secrets") and ask
each finding for Severity and Blocks: yes|no. Additive rule: a finding is
CRITICAL when its label rule says so or it says Blocks: yes; Blocks: no never
lowers one (proseVoiceSeverity, BLOCKING_FLOOR in lib/review-scope.ts).
Part 3: ROLE_EFFORT puts specialists at medium; Red Team, native adversarial
and fix-check stay full; light's batched specialist (carries the Red Team
prompt) stays full; --no-tiers sends specialists to host.
Repinned reviewer briefs with no-loss replay G1 (live Arm G1, not yet run):
ship/sections/review-army.md, ship/sections/adversarial.md,
review/sections/adversarial.md, lib/review-depth.ts. Merge only on G1's pass.
Review-skill parity ratio 1.3136 -> 1.3180 and the gstack-review size pins
+537 for the approved +0.3k tokens per voice.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… at every depth (GSTA-167) planReview dispatches one 'specialist batched' at standard and full depth (and light, which adds the Red Team checklist): Testing and Security always on code and gate class, plus State-machines, Data-migration, API-contract and Design when scope asks; a forced checklist always joins. Maintainability, Performance and Simplification are read only when forced (SKIP names them). LIGHT_FIXED is [testing, security]; BATCH_SCOPED joins DEPTH_RULES so old receipts re-plan. The Red Team rule and prompt are unchanged; it reads the batched reader's merged findings. specialistsFor stays as the legacy selection the dispatch compare script models. Repinned reviewer briefs with no-loss replay L (live Arm L, scored L∘G1 vs G1; not yet run): ship/sections/review-army.md, lib/review-depth.ts. Merge only on L's pass. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…CRITICAL, batched checklists by name (GSTA-167) Integrates parts 1 and 2 with gstack-review-dispatch (#3648): - lib/review-ledger.ts parseFindings: a prose voice's "Blocks: yes" makes its own line, or the finding on the line just before it, CRITICAL in merged.jsonl (normalizer v2, certified by round 5's G1), so judge refuses a lead that keeps it below the floor; with no finding before it the Blocks line is its own CRITICAL finding. "Blocks: no" never lowers a label. - lib/review-brief.ts: the outside-voice brief no longer appends "Give each finding a severity"; the section's prompt now asks for Severity and Blocks, so the brief is the certified section prompt plus the branch diff. - bin/gstack-review-dispatch render --checklists takes the plan's checklists= names (review/specialists/<name>.md) as well as paths and refuses an unknown one, since the batched reader is now every depth's specialist dispatch. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
…ect reads separate-line Severity/Blocks /ship pass 1 (PR #3660): the Red Team CRITICAL at lib/review-collect.ts:120 and the informational findings in the same batch. proseVoiceSeverity had no caller and is removed; the normalizer v2 table now runs through parseFindings, the path collect uses. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
/ship pass 2 (PR #3660): an unlabeled line carrying an inline Blocks: yes collects as CRITICAL again; Severity/Blocks continuation needs a colon, stops at a list item, heading, bold paragraph opener or a repeated field, and never swallows a top-level bullet or its section label; the native voice's FIXABLE collects as CRITICAL under its role with or without a dispatch name; the consumer scan adds --no-color. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…; explicit Severity wins its line /ship pass 2 Red Team (PR #3660): prose after a finding's Severity/Blocks field, a post-blank paragraph or a line in an indented block starts the next finding, and a line's explicit Severity: label decides it over other label words on the line. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… keeps its own id and subject /ship fix-check (PR #3660): labels are named before the strongest is taken, so a one-line native FIXABLE ... Severity: Medium collects as CRITICAL; a later finding starts at a file:line after the open finding's fields, field bullets stay on their finding, a field line may omit the colon, and continuation prose never replaces a list item's subject. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…onsumer-scan fixes Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
3 tasks done
garrytan
added a commit
that referenced
this pull request
Oct 31, 2026
… changed briefs under a pending GSTA-160 replay entry The resolver floor now extends lib/review-scope.ts BLOCKING_FLOOR (the prose voices' copy) with the security clause, so every copy contains #3660's floor words and the voices stay at G1 bytes. fix-check carries the sentence literally for the F10 copy check. Two review-skill lines are shortened to keep the generated SKILL.md size pins from growing. Replay: 4c53e80a (pre-#3660 wording); GSTA-167 cohort no-loss arm on these bytes pending. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Both prose voices now carry the blocking floor and end each finding with Severity and Blocks, so a blocker no longer depends on which severity word a voice picks.
Before/after as text: Both prose voices now carry the blocking floor and end each finding with Severity and Blocks, so a blocker no longer depends on which severity word a voice picks
git.capy.ai
✓ Logged in to git.capy.ai account garrytan (/etc/capy/gh/hosts.yml)
This PR ships GSTA-167 variant G, the certified reviewer stack for
/ship, in four parts:Severity:andBlocks: yes|no.gstack-review-dispatch collectrecordsBlocks: yesand the native voice's FIXABLE as CRITICAL, andBlocks: nonever lowers a finding.classifyDiff. An untested state-matrix cell is a test gap below the floor.Why
"Are you learning that the ship review loop is too overzealous?" Reviewers are about half the cost of a gate-class
/ship, and most blockers that earlier variants missed were severity labels flipping on the same defect. The floor sentence fixes the labels at no cost, which leaves room to cut readers without losing blockers.Certification
gstack-review-dispatch renderproduces the certified arms' briefs byte for byte (handoffs/GSTA-167/reviewers-brief-parity.md). The /ship fixes below touch onlycollectand the consumer scan, never a brief.Approvals
Source: gstack-approvals record for gsta-167-reviewers (display only; not an approval citation).
Blast radius
The change touches every
/shipand/reviewrun through the rendered briefs,gstack-review-plan,gstack-review-dispatch collectand the receipt's depth recompute. It is safe because the briefs main renders with this stack match the certified arms byte for byte (script ran: handoffs/GSTA-167/reviewers-brief-parity.md), and both no-loss replays passed on those briefs (round 5: 24 of 29 against 21, p=0.035; round 6: 33 of 41 against 27, p=0.0055).Summary
The /ship review of this PR found that
collectand the data-file consumer scan could lose a blocker, and those fixes ride here. The consumer scan now readsgit grepthe same way under any git config, sogrep.lineNumber,grep.columnorcolor.grepcan no longer make every data file look unread.collectnow joins aSeverity:orBlocks:line to the finding above it, keeps an inlineBlocks: yesas CRITICAL, and gives each finding its own id. When the layout is unclear, it merges findings rather than dropping one.Test Coverage
Coverage: 92% value-weighted (92% including 0 weakly covered paths), 24 of 26 new code paths (Step 7 audit at 82777f1). Both gaps are closed now:
scanConsumers's grep-failure path has a test (consumer_scan_failed), and a missing--checklistsname was probed in QA (checklist not found, exit 1). Test value: 0 tests written by the audit; the /ship fixes added regression tests, and each fails at the commit before its fix and passes after it (grep config, inlineBlocks: yes, paragraph and field layouts, one-line native FIXABLE).Tests ran: typecheck count unavailable
Tests ran: guards 28
Tests ran: review 1135
Pre-Landing Review
Pass 1 (full, gate class, 6 specialists plus Red Team) found one blocker: the consumer scan failed open under
grep.lineNumber/grep.column(fixed in 8fb3b41). Pass 2 on the range (6 specialists, Red Team, native adversarial, cross-family outside voice) found that the pass-1 parser rewrite could drop an inlineBlocks: yes, merge separate findings, or attach a later finding's fields to an earlier one (fixed in 7a3e6d9 and a72d862). Fix-check 1 found a one-line native FIXABLE collecting below CRITICAL (fixed in 7a6de9c). Fix-check 2 came back clean.REVIEW_LOOP: passes=2 blocking_found=8 deferred=0 noted=7 fixed=31 scope=frozen fix_checks=2 dispatches=14
Gate edits: none detected (tagged=0)
Outside review: completed by a cross-family subagent on openai/gpt-6.1-sol (no Codex CLI on this machine); 2 findings, both fixed.
Review notes
readdirSync, a glob, a template path) never matches the basename grep, so it reviews as docs (lib/review-depth.ts:137, a pinned certified file; changing it needs a no-loss replay).--no-columnneeds git 2.19 or later; older git fails the scan closed (every data file stays code).collectkeeps the outside voice's High, P0 and P1 as written (main'scollect keeps raw labelscontract), so lead judgment still applies that half of the label rule.Severity: Low (not High)collects as High; a top-level- Severity:bullet with no file:line joins the open finding; a continuation line naming another file:line, or a ratio such as0.5:1, starts a new finding. No blocker is lost in any of these.Exploratory QA
CLI surface, 17 probes plus 6
Blocks:variants at 82777f1 (Step 9.2.1):gstack-review-planJSON and--force,render --checklistsby name and path and its rejections,collecton JSON and prose voices, and state-matrix findings all passed. No defects were verified. Thegstack-ship-preflightprobe was blocked, so preflight is only partly covered; it ran end to end in this /ship's own Step 0.9.Plan Completion
Plan items: parts 1-4 and the #3648 dispatch wiring, rebased as four commits onto main with
git range-diff4 of 4 equal; all shipped here.Verification Results
Remote pregate at e8fcca5: 19,038 tests, 0 failed, on Ubicloud ($0.10); the macOS and Windows lanes are cleared by CI runs 41161914710 and 41161914701. CI at e8fcca5: every check passed.
Issues
Refs #3648
Refs #3660
TODOS
No TODO items completed in this PR.
Documentation
Status: current. The docs already match the change, and no edits were needed.
Scope: base 2127729 to head e8fcca5 on gsta-167-reviewers, 37 committed files, with no staged, unstaged or new files. Authored docs reviewed: docs/review-policy.md, docs/model-policy.md, docs/skills.md, capy/skill/gstack/SKILL.md, ship/sections/review-army.md.tmpl and changelog.d/gsta-167-reviewers.md, plus the generated review-army and adversarial sections. README, CONTRIBUTING, AGENTS.md and docs/ were searched for stale reviewer and effort claims, and none were found.
Documentation health:
Coverage debt: the data-file rule and the Blocks: floor have reference coverage only, with no how-to. No diagram drift was found.
Test plan
bun run typecheck: exit 0bun test test/parity-suite.test.ts test/skill-md-size-guard.test.ts test/module-size-ratchet.test.ts test/spawnsync-timeout-tripwire.test.ts test/bun-entry-isolation.test.ts test/state-root-ratchet.test.ts: 28 pass, 0 failbun test --timeout 60000on the 13 review, ship and skill test files: 1135 pass, 0 failUBI_OWNER=gsta167 gstack-pregate --stage tests --remote --spend-cap 2: 19,038 tests, 0 failed