Skip to content

v1.91.378.0 fix(cso): pin scout-sbom-indexer source to 1.24.0, refuse floating source tags (GST-495) - #3699

Merged
capy-ai[bot] merged 5 commits into
mainfrom
capy/gst-495-cso-sbom-release-tag
Oct 31, 2026
Merged

capy-ai[bot] merged 5 commits into
mainfrom
capy/gst-495-cso-sbom-release-tag

Conversation

@garrytan

@garrytan garrytan commented Oct 31, 2026 •

Copy link
Copy Markdown
Owner
{
  "schema_version": 1,
  "pr": 3699,
  "head": "291dee91a72bea9dd7b107781c65e731e0b15329",
  "version": "1.91.371.0",
  "base": "main",
  "gate": {
    "cso": {
      "pass": 77,
      "fail": 0,
      "skip": 0
    },
    "typecheck": {
      "pass": 1,
      "fail": 0,
      "skip": 0
    }
  },
  "session_kind": "unattended",
  "head_tree": "421cc93cd721fad97a212c42862c500dfc31fca4",
  "product_patch_id": "e90f2da528a1ef386ee03703f91b19640c789eb5",
  "gstack_version": "1.91.371.0",
  "review_depth": {
    "depth": "light",
    "class": "code",
    "runtime_lines": 9,
    "rules": "150435b0a543019a",
    "base": "44eeeb3c9b8011f17a44cb234fdf052afef660f8",
    "registry": "44eeeb3c9b8011f17a44cb234fdf052afef660f8",
    "gate_scan": {
      "tagged": 0,
      "head": "291dee91a72bea9dd7b107781c65e731e0b15329"
    },
    "reasons": [
      "runtime=9<=50"
    ]
  },
  "pregate": "requires-remote cleared @421cc93cd721 (1 checks, current for 291dee91a72b)",
  "requires_remote": [
    "windows-free-tests.yml/windows-free-shard: https://github.com/garrytan/gstack/actions/runs/41216564534",
    "pregate.json/remote_gate: remote-gate tree=421cc93cd721 tests=314"
  ],
  "issues": {
    "fixes": [],
    "refs": [],
    "flakes": []
  },
  "docs": {
    "status": "updated",
    "scope": "docs/, lib/cso/images/README.md, README.md (CSO release qualification and scanner docs read in full)"
  },
  "review_loop": {
    "passes": 1,
    "blocking_found": 0,
    "deferred": 0,
    "noted": 2,
    "fixed": 0,
    "scope": "frozen",
    "fix_checks": 1,
    "dispatches": {
      "specialist": 1
    }
  }
}

What changed

Docker moved scout-sbom-indexer:1 to 1.29.0, so the reviewed 1.24.0 pins failed SOURCE_TAG_MOVED; the source now names the exact 1.24.0 release and verifies

Docker moved scout-sbom-indexer:1 to 1.29.0, so the reviewed 1.24.0 pins failed SOURCE_TAG_MOVED. The source now names the exact 1.24.0 release, and the check passes.

Before/after as text: Docker moved scout-sbom-indexer:1 to 1.29.0, so the reviewed 1.24.0 pins failed SOURCE_TAG_MOVED; the source now names the exact 1.24.0 release and verifies
--- Before · before.txt · captured output
+++ After · after.txt · captured output
+$ CSO_STACK=node CSO_PLATFORM=linux/amd64 bun run scripts/cso-verify-runtime-base.ts   # PR #3699 @ 59fe1a0
+verified node-24.4.0-amd64 base manifests and versions
+exit=0
-$ CSO_STACK=node CSO_PLATFORM=linux/amd64 bun run scripts/cso-verify-runtime-base.ts   # main @ 44eeeb3
-SOURCE_TAG_MOVED: docker.io/docker/scout-sbom-indexer:1
-exit=1
 
 $ jq .sbomGenerator.source lib/cso/images/build-inputs.json
+"docker.io/docker/scout-sbom-indexer:1.24.0"
-"docker.io/docker/scout-sbom-indexer:1"
 

Why

"All 10 validate-native jobs in the Stage CSO Runtime Images workflow fail with SOURCE_TAG_MOVED: docker.io/docker/scout-sbom-indexer:1" (run 41212876036 on #3697, GST-495). Every PR that touched a CSO path went red, test-only changes included. With this change the workflow is green again (10 of 10 validate-native jobs passed at b83f0c9). A floating source tag can no longer be reviewed into the build inputs.

Blast radius

The source tag is a provenance label. The SBOM generator digests and the build-inputs revision are byte-identical, so no requalification trigger changes and the 10 qualified catalog runtimes stay current. bun scripts/cso-requalification.ts check lib/cso/runtime-catalog.json prints REQUALIFICATION CURRENT. The promotion checks compare revision, stack, platform and versions, never the source tag (scripts/cso-runtime-promotion.ts, read). The new tag check runs only in imageBuildMatrix. Every committed source passes it. The fix-check reviewer checked each one, and committedImageBuildMatrix() builds all 10 rows in the test. scripts/ is outside the image source closure, so preparationSha256 is unchanged.

Approvals

Date Asked Exact words Outcome Covers Still pending
2026-10-31 GST-495 fix-lane plan: sbomGenerator.source to :1.24.0, floating-tag reject in assertPinnedFamily “do it: approved as written, including the :1.24.0 source pin and the floating-tag reject in assertPinnedFamily. Moving to 1.29.0 stays out of scope. Build, /ship and READY.” (GStack Minder (GSTA-36)) approved GST-495 / GSTA-201 / PR #3699 none

Source: gstack-approvals record for capy/gst-495-cso-sbom-release-tag (display only; not an approval citation).

Summary

Docker pushed scout-sbom-indexer 1.29.0 to the floating :1 tag on 2026-10-29. The reviewed index sha256:4b67f29e… is Docker's 1.24.0 release, and the 1.24.0 tag still points at it. So this PR points sbomGenerator.source at :1.24.0 instead of moving any digest.

Why not re-pin to 1.29.0? That changes the digests, so it needs a new build-inputs revision, which is a requalification trigger. The catalog would go stale, and test/cso-requalification.test.ts would fail until a protected-main staging run, the private evaluator and a maintainer approval requalify all 10 runtimes. A PR can't do that before merge. Upgrading the generator stays a separate, deliberate requalification.

Recurrence: an exact release tag, not a digest-addressed source. A digest source such as :1@sha256:… would make SOURCE_TAG_MOVED compare a digest with itself, so it would always pass and we'd lose the signal that upstream re-pushed a release. Instead, assertPinnedFamily now requires every pinned family (SBOM generator, base images, uv) to name an exact release: <major>.<minor>.<patch>, or <major>.<minor> for the PostgreSQL base, whose releases have two parts. A floating major or minor tag, latest or another alias fails with FLOATING_<FAMILY>_SOURCE before any build. Exact tags can still be re-pushed (Docker's official images rebuild them when their Debian base changes). SOURCE_TAG_MOVED still reports that, and fixing it is a reviewed change.

Test Coverage

All new code paths have test coverage: each changed runtime file has a changed test that names it.
Tests ran: cso 77
Tests ran: typecheck count unavailable

Pre-Landing Review

Pass 1 (batched specialist) and the native adversarial pass found no blocking defect. One finding was fixed: both reviewers noted that the first version of the tag check still accepted floating major.minor tags such as :1.24. The check now requires major.minor.patch, with two parts allowed only for PostgreSQL. A full-effort fix-check read that fix and returned NO FINDINGS.
REVIEW_LOOP: passes=1 blocking_found=0 deferred=0 noted=2 fixed=0 scope=frozen fix_checks=1 dispatches=1
Gate edits: none detected (1 listed, 0 read; patterns: RH-1,RH-3,RH-4,RH-12,RH-13,RH-14,RH-15,RH-16; unlisted idioms: none)
Outside review: skipped by the review plan (code class, no numeric claims).

Review notes

  • test/cso-distribution.test.ts: the literal 1.24.0 assertion overlaps with the committed-matrix check. It is kept on purpose, because it records the reviewed pin, and any future bump is itself a reviewed change.
  • Exact official-image tags (node:24.4.0-bookworm-slim and the others) can be rebuilt upstream, and SOURCE_TAG_MOVED would then fail the same way for a base image. Base images are outside this change. Whether a moved tag with an unchanged pinned digest should fail hard is a separate decision.

Exploratory QA

Smoke: bun scripts/cso-image-matrix.ts on the committed inputs prints 10 rows with the 1.24.0 source. The same script on a copy whose source is :1 exits 1 with FLOATING_SBOM_GENERATOR_SOURCE. cso-verify-runtime-base.ts passes for node and bun on linux/amd64 on this branch and fails with SOURCE_TAG_MOVED on main (see the image above). The arm64 rows are covered by CI's native arm runners.

Design Review

No frontend files changed — design review skipped.

Eval Results

No prompt-related files changed — evals skipped.

Plan Completion

Plan completion audit: not run (no plan is bound to this branch and no docs/designs/ file matches). The fix-lane plan GStack Minder approved is in Approvals above.

TODOS

No TODO items completed in this PR.

Documentation

Status: updated. One factual clarification, no blockers.

Scope: committed diff 48599bb..HEAD (build-inputs.json, cso-image-matrix.ts, cso-distribution.test.ts, docs/cso-release-qualification.md, changelog fragment); nothing staged, unstaged or untracked.

Documentation health:

  • docs/cso-release-qualification.md: Updated. The exact-release source tag rule now names every pinned family (bases, Python's uv, SBOM generator), as assertPinnedFamily enforces.
  • lib/cso/images/README.md: Current. Its tag re-resolution description is unaffected.
  • docs/cso-scanners.md: Current. It covers scanner-images inputs, which are out of this diff.

Coverage debt: FLOATING_<FAMILY>_SOURCE has reference coverage only, in docs/cso-release-qualification.md, with no troubleshooting entry (common gap). No diagram drift.

Test plan

  • bun test test/cso-distribution.test.ts test/cso-requalification.test.ts test/cso-runtime-promotion.test.ts: 77 pass, 0 fail
  • bun run typecheck: clean
  • Remote pregate (Ubicloud): 314 tests, 0 failed on tree 421cc93cd721 ($0.03)
  • Stage CSO Runtime Images on this PR: 10 of 10 validate-native jobs green

…use floating source tags (GST-495)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@trunk-io

trunk-io Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

😎 This pull request was merged.

garrytan and others added 4 commits October 31, 2026 15:42
…postgresql)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@capy-ai
capy-ai Bot marked this pull request as ready for review October 31, 2026 16:05
@github-actions github-actions Bot changed the title fix(cso): pin scout-sbom-indexer source to 1.24.0, refuse floating source tags (GST-495) v1.91.378.0 fix(cso): pin scout-sbom-indexer source to 1.24.0, refuse floating source tags (GST-495) Oct 31, 2026
@capy-ai
capy-ai Bot merged commit 3bfe566 into main Oct 31, 2026
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant