Repository navigation
v1.91.378.0 fix(cso): pin scout-sbom-indexer source to 1.24.0, refuse floating source tags (GST-495) - #3699
Merged
Conversation
…use floating source tags (GST-495) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
…postgresql) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Docker moved
scout-sbom-indexer:1to 1.29.0, so the reviewed 1.24.0 pins failedSOURCE_TAG_MOVED. The source now names the exact 1.24.0 release, and the check passes.Before/after as text: Docker moved scout-sbom-indexer:1 to 1.29.0, so the reviewed 1.24.0 pins failed SOURCE_TAG_MOVED; the source now names the exact 1.24.0 release and verifies
Why
"All 10
validate-nativejobs in the Stage CSO Runtime Images workflow fail withSOURCE_TAG_MOVED: docker.io/docker/scout-sbom-indexer:1" (run 41212876036 on #3697, GST-495). Every PR that touched a CSO path went red, test-only changes included. With this change the workflow is green again (10 of 10validate-nativejobs passed at b83f0c9). A floating source tag can no longer be reviewed into the build inputs.Blast radius
The source tag is a provenance label. The SBOM generator digests and the build-inputs
revisionare byte-identical, so no requalification trigger changes and the 10 qualified catalog runtimes stay current.bun scripts/cso-requalification.ts check lib/cso/runtime-catalog.jsonprintsREQUALIFICATION CURRENT. The promotion checks compare revision, stack, platform and versions, never the source tag (scripts/cso-runtime-promotion.ts, read). The new tag check runs only inimageBuildMatrix. Every committed source passes it. The fix-check reviewer checked each one, andcommittedImageBuildMatrix()builds all 10 rows in the test.scripts/is outside the image source closure, sopreparationSha256is unchanged.Approvals
Source: gstack-approvals record for capy/gst-495-cso-sbom-release-tag (display only; not an approval citation).
Summary
Docker pushed scout-sbom-indexer 1.29.0 to the floating
:1tag on 2026-10-29. The reviewed indexsha256:4b67f29e…is Docker's 1.24.0 release, and the1.24.0tag still points at it. So this PR pointssbomGenerator.sourceat:1.24.0instead of moving any digest.Why not re-pin to 1.29.0? That changes the digests, so it needs a new build-inputs
revision, which is a requalification trigger. The catalog would go stale, andtest/cso-requalification.test.tswould fail until a protected-main staging run, the private evaluator and a maintainer approval requalify all 10 runtimes. A PR can't do that before merge. Upgrading the generator stays a separate, deliberate requalification.Recurrence: an exact release tag, not a digest-addressed source. A digest source such as
:1@sha256:…would makeSOURCE_TAG_MOVEDcompare a digest with itself, so it would always pass and we'd lose the signal that upstream re-pushed a release. Instead,assertPinnedFamilynow requires every pinned family (SBOM generator, base images, uv) to name an exact release:<major>.<minor>.<patch>, or<major>.<minor>for the PostgreSQL base, whose releases have two parts. A floating major or minor tag,latestor another alias fails withFLOATING_<FAMILY>_SOURCEbefore any build. Exact tags can still be re-pushed (Docker's official images rebuild them when their Debian base changes).SOURCE_TAG_MOVEDstill reports that, and fixing it is a reviewed change.Test Coverage
All new code paths have test coverage: each changed runtime file has a changed test that names it.
Tests ran: cso 77
Tests ran: typecheck count unavailable
Pre-Landing Review
Pass 1 (batched specialist) and the native adversarial pass found no blocking defect. One finding was fixed: both reviewers noted that the first version of the tag check still accepted floating
major.minortags such as:1.24. The check now requiresmajor.minor.patch, with two parts allowed only for PostgreSQL. A full-effort fix-check read that fix and returned NO FINDINGS.REVIEW_LOOP: passes=1 blocking_found=0 deferred=0 noted=2 fixed=0 scope=frozen fix_checks=1 dispatches=1
Gate edits: none detected (1 listed, 0 read; patterns: RH-1,RH-3,RH-4,RH-12,RH-13,RH-14,RH-15,RH-16; unlisted idioms: none)
Outside review: skipped by the review plan (code class, no numeric claims).
Review notes
test/cso-distribution.test.ts: the literal1.24.0assertion overlaps with the committed-matrix check. It is kept on purpose, because it records the reviewed pin, and any future bump is itself a reviewed change.node:24.4.0-bookworm-slimand the others) can be rebuilt upstream, andSOURCE_TAG_MOVEDwould then fail the same way for a base image. Base images are outside this change. Whether a moved tag with an unchanged pinned digest should fail hard is a separate decision.Exploratory QA
Smoke:
bun scripts/cso-image-matrix.tson the committed inputs prints 10 rows with the1.24.0source. The same script on a copy whose source is:1exits 1 withFLOATING_SBOM_GENERATOR_SOURCE.cso-verify-runtime-base.tspasses fornodeandbunon linux/amd64 on this branch and fails withSOURCE_TAG_MOVEDon main (see the image above). The arm64 rows are covered by CI's native arm runners.Design Review
No frontend files changed — design review skipped.
Eval Results
No prompt-related files changed — evals skipped.
Plan Completion
Plan completion audit: not run (no plan is bound to this branch and no docs/designs/ file matches). The fix-lane plan GStack Minder approved is in Approvals above.
TODOS
No TODO items completed in this PR.
Documentation
Status: updated. One factual clarification, no blockers.
Scope: committed diff 48599bb..HEAD (build-inputs.json, cso-image-matrix.ts, cso-distribution.test.ts, docs/cso-release-qualification.md, changelog fragment); nothing staged, unstaged or untracked.
Documentation health:
docs/cso-release-qualification.md: Updated. The exact-release source tag rule now names every pinned family (bases, Python's uv, SBOM generator), asassertPinnedFamilyenforces.lib/cso/images/README.md: Current. Its tag re-resolution description is unaffected.docs/cso-scanners.md: Current. It covers scanner-images inputs, which are out of this diff.Coverage debt:
FLOATING_<FAMILY>_SOURCEhas reference coverage only, in docs/cso-release-qualification.md, with no troubleshooting entry (common gap). No diagram drift.Test plan
bun test test/cso-distribution.test.ts test/cso-requalification.test.ts test/cso-runtime-promotion.test.ts: 77 pass, 0 failbun run typecheck: cleanvalidate-nativejobs green