Repository navigation
v1.92.24.0 fix(ship): finish accepts an owner-accepted documentation exception (GST-713) - #3776
Merged
Merged
Conversation
…ested fixes no longer force a second review loop (GST-407, GST-384, GST-391) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…-triggers Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # ship/DRIVER.md # ship/DRIVER.md.tmpl
…ds; trim elsewhere Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
comparePath returns same only when every hunk sits where the base change puts it (patch-ids ignore positions) and treats a file-mode change as changed; the scoped-review packet says when a fence is truncated; --docs-result must be the posted audit's result; the --context-reviewed record goes beside the packet, outside the worktree. Negative controls for each. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
A test edit routes as tests= only when it adds lines with no gate tag; a removed or changed line or an unreadable test diff goes through the full loop. Diffs skip textconv. A hunkless patch (binary, empty, mode-only) is same when its patch-id matches. Without --reviewed-base test files route as before. finish's packet path and attempt's state directory have fallbacks. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ew is release metadata (GBRA-251) gateEditedPaths reads removed lines only inside hunks; carry refuses when a path listing fails; docs freshness stops on a failed listing; attempt counts an unreadable state file. releasePaths includes stamp_files paths whose edit is a version swap under stamp_patterns. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…t state A test-only edit with no gate tag gets the scoped fix-check of its test hunks instead of a lanes-only rerun. Packet write failures print a STOP or RECEIPT_CARRY_REFUSED. attempt's allowance uses an exclusive create. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…t diff outside context paths The attempt STOP no longer echoes the audit child's fix text. A scoped-review carry now requires the product patch-id without the context paths to match at both heads. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ch; name-only test globs only in test dirs A scoped-review packet section over 200 lines sends that path to the full loop instead of a truncated packet. The docs-result path match is exact. test_*.py, *Test.java and similar count as test code only under a test directory. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…roubleshooting (docs-a-1) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…like ship-release (run 41193336209) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…-triggers Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # bin/gstack-ship-receipt
…-triggers Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # bin/gstack-ship-receipt
The merge commit b10e2db wrote a truncated copy of the file. This is the three-way merge of both sides with the refused() union: main's codes plus RECEIPT_CARRY_SCOPED_REVIEW. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…n exception (GST-713) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…l are covered (GST-713) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ish also matches scope and stops on a corrupt docs-audit record (GST-713) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…(GST-713) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…n-finish Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # bin/gstack-docs-candidate # lib/ship-release.ts
capy-ai
Bot
changed the base branch from
gst-407-ship-rereview-triggers
to
main
November 1, 2026 07:17
|
😎 This pull request was merged. |
…OG.md on main Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was wrong
When the owner accepted a Step 14.5 documentation exception (a blocked docs audit with a written
docs.exception), nothing recorded that acceptance in the post-audit snapshot, sogstack-ship-release finishstopped on the blocked audit with no way through. The only exit was to hand-edit state or skipfinish.What changed
gstack-docs-candidate snapshot --exception <docs-audit.json>reads the audit record with the receipt's own docs parser (parseReceiptDocs) and writes the exception (who accepted it, date, via, reason, base SHA and audit scope) into the snapshot. It refuses a record that is missing, corrupt, not blocked, or carries no complete exception.finish(lib/ship-release.ts) accepts a blocked audit only when the snapshot's exception matches the current.gstack/tmp/docs-audit.jsonexception, base and scope, and prints it on theDOCS:line. A blocked audit with no exception, a mismatched one, or a corrupt record still stopsfinish.--exceptionsnapshot step.Proof
test/ship-release-docs-exception.test.ts was written first and failed on the base:
finishstopped on an accepted exception. It now passes, together with the refusal cases (no exception, mismatch, corrupt record, everysnapshot --exceptionrefusal).Review notes
parseReceiptDocs, match scope, stop on a corrupt record).finishcalls a non-blocked audit that carries an exception "blocked". Only a hand-edited record reaches that state.Summary
Stacked on #3684 (
gst-407-ship-rereview-triggers); I retarget it tomainwhen #3684 lands.When the owner accepts a Step 14.5 documentation exception,
gstack-docs-candidate snapshot --exception .gstack/tmp/docs-audit.jsonnow writes the post-audit snapshot with the exception in it: who accepted it, the date, the relay, the reason, the audit scope and the base SHA.gstack-ship-release finishaccepts a blocked audit only when that recorded exception matches the current.gstack/tmp/docs-audit.json(same exception, same scope), and prints it on itsDOCS:line. The snapshot reads the record with the receipt's own docs parser, so the two can't disagree about what a valid exception is.Why
GST-713 (GEVA-84 on gstack-evals#102): an accepted exception means the docs audit reader is skipped, so no post-audit snapshot exists, and
finishrequires one. Before this change an owner-accepted exception could never finish. The only ways out were to hand-edit state or skipfinish.Proof, failing first.
test/ship-release-docs-exception.test.tsfailed on the base b6a5bd1:snapshot --exceptionwas an unknown argument andfinishstopped for want of--docs-post. It now passes, along with the refusal cases. They cover a blocked audit with no exception, a snapshot whosedocs-audit.jsonlost or changed its exception, a changed scope, a corrupt record, and everysnapshot --exceptionrefusal.Blast radius
bin/gstack-docs-candidate(one new flag) and the docs stage offinishinlib/ship-release.ts. Without--exception, snapshots are byte-for-byte what they were.finishstill stops on a blocked audit nobody accepted. The ship documentation section and its template, and theDOCS_AUDIT_BLOCKEDentry in docs/troubleshooting.md, name the new step. It adds no network calls, environment reads, permission changes, workflow edits or dependencies.Approvals
GStack Minder (GSTA-36) added GST-713 to this lane: "fix so the accepted exception writes a record naming the exception (who accepted it, base SHA) and finish accepts it, without letting finish pass when no exception was accepted."
Pre-Landing Review
Pre-Landing Review: 3 issues — 2 fixed, 0 deferred, 1 noted
Gate edits: none detected
Documentation
Scope: the candidate's 7 selected paths (gstack-docs-candidate --exception, ship-release finish exception handling, documentation.md and its .tmpl, the changelog fragment, the new test, a ship receipt fixture), plus docs that reference gstack-docs-candidate, DOCS_AUDIT_BLOCKED or finish. Result: the ship section and its template agree, and the changelog fragment is accurate. One gap fixed: docs/troubleshooting.md DOCS_AUDIT_BLOCKED did not mention saving the post snapshot with --exception or that finish stops without it. Debt: none found. Doc caps were not checked on the edited file, and the generated ship/SKILL.md and golden copies were not regenerated or checked, per the no-generation rule.