Repository navigation
v1.92.75.0 fix(ship): the receipt counts every blocker the readers found (GST-951) - #3845
Merged
Merged
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…and tests from review pass 1 (GST-951) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…sification wins; ledgers_read (GST-951 Step 11 findings) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…less loci; pr-body names no targeted ledger (GST-951 round-2 findings, pending grant) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The receipt's blocker count now includes what the readers found in the dispatch ledgers: 9 becomes 12 on this PR's own review, and 4 blockers with no recorded disposition are named.
Text version: on origin/main dd9834d the summary counts nine blockers for this PR's own review. On this branch it counts twelve, names four with no recorded disposition, and says it read four ledgers.
Why
The receipts for #3841, #3838 and #3837 said no blockers were found, even though their readers raised real CRITICALs that got fixed. The summary only counted review-log rows stamped blocking, while /ship's readers report through the dispatch ledgers. Now the receipt counts every blocker any reader found, and it refuses to write a count when it can't read the ledgers it needs.
Blast radius
This touches every
gstack-review-scope summarycaller: ship/DRIVER.md now passes--run, the Claude Code pr-body section passes--no-ledger, and the four existing test call sites got--no-ledger; a caller that passes none of the three now getsREVIEW_SCOPE_LEDGERinstead of a quiet undercount. The remote pregate ran the whole selected free tier (25289 tests, 0 failed on tree e496909f), and the receipt reader accepts receipts without the two new keys.Approvals
Source: gstack-approvals record for gst-951-receipt-counts-blockers (display only; not an approval citation).
Summary
summaryalso reads every ledger's collected and judged CRITICAL findings (ledgerBlockersin lib/review-ledger.ts). Each one pairs with at most one row finding from the same reviewer at the same path:line, so a blocker held in both places counts once and one a row classified below the floor does not; an unclassified CRITICAL row counts as blocking. It printsunrecorded(blockers no row gives a disposition) andledgers_read, and the schema, types andparseReviewLoopcarry both. It needs--run <dir>,--ledger <f>or--no-ledger; a missing choice, a run dir with no ledger, an unreadable ledger, merged file or judged set, or a judged set changed sincejudgeis the newREVIEW_SCOPE_LEDGERresult code with nothing written (troubleshooting and doctor anchors added). DRIVER.md stays at 12262 bytes.Test Coverage
test/review-scope-ledger-count.test.ts derives every count from ledgers and logs (the PR cases are reconstructions, labeled as such). Regression proof: on origin/main dd9834d it fails 10 of 10; at this head it passes 10 of 10.
Tests ran: remote_gate 25289
Pre-Landing Review
Two review rounds on the full panel (gate-class), then the Captain's granted fix-check on 15823cc; the targeted money reader found nothing on the final tree.
REVIEW_LOOP: passes=2 blocking_found=12 deferred=0 noted=7 fixed=15 scope=frozen unrecorded=4 ledgers_read=4 fix_checks=1 dispatches=11
Review-loop exception: accepted by GStack Minder (Captain, GSTA-36) 2026-11-02 via the GSTA-167 lane parent relaying the Captain's rule 23 grant: one scoped fix-check after round 2 on the five counting gaps; its findings ship as open notes (fix-check at 15823cc, 3 findings)
Review notes
Open notes from the granted fix-check (no further rounds):
core,unknownor noraised_bypair with any reviewer's ledger blocker, so a below-floor core row can still absorb another reviewer's CRITICAL at that line.raiserOfskipsraisedBy's normalization (lowercasing, theadversarialalias, the specialist field), so a row raised byadversarialand itsadversarial-nativeledger finding count twice and show one false unrecorded.No network calls, secrets, permissions, workflows, install scripts or dependencies change.
Documentation
Status: updated. Scope: docs/ and ship/sections/ (git diff origin/main...HEAD). docs/review-policy.md's code map lists
unrecorded,ledgers_readandREVIEW_SCOPE_LEDGER; docs/ship-policy.md's refusal list linksREVIEW_SCOPE_LEDGER.Test plan