Repository navigation
v1.94.12.0 fix(review-depth): character references and HTML comment ends no longer hide SVG style CSS (GST-940) - #3866
Merged
Merged
Conversation
…ends keep an SVG code (GST-940, failing) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…mments as CSS (GST-940) No-loss replay GST-940: 62,805 unique SVG files give the same verdict as main at 4bbad24, and the planner over the last 100 first-parent main commits changes no depth, class or risk class. Repins lib/review-depth.ts on GST-940. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
…ain style comments stay a drawing (GST-940, failing) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…-team#1) No-loss replay GST-940 rerun: 62,805 unique SVG files keep main's verdict and the planner over 100 main commits changes nothing. Repins lib/review-depth.ts on GST-940. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…refixes keep an SVG code (GST-940 fix-check, failing) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…II element and attribute names (GST-940 fix-check) Fixes round-2 red-team#1 and targeted#1 under the Captain's scoped fix-check grant. No-loss replay GST-940 rerun: 62,805 unique SVG files keep main's verdict; the planner over 100 main commits changes nothing. Repins lib/review-depth.ts on GST-940. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…gst-940-style-charref Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # test/review-packets-removed.test.ts
…ter the main merge Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…gst-940-style-charref Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # test/review-packets-removed.test.ts
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An SVG chart counts as data, and gets a light review, only when its whole text is a drawing. Six markup shapes let an SVG that loads remote content or runs script pass as a drawing (GST-940 plus four that review found). Three hid CSS from the style walker:
</style>faked a closing tag and<!--a comment, because the walker read decoded text, and a comment that only an HTML parser ends early (<!-->,--!>) exposed CSS the walker dropped. Review found three more: a>inside a quoted attribute on<style>, a Unicode space (U+00A0, U+000B) before the>of</style>, and a non-ASCII namespace prefix (<gé:script>,xé:href) that read as an allowed name or was never read.What changed
lib/review-depth.tssvgDrawing: walks each style element over the raw text and refuses any&in its body. It reads comments and CDATA as CSS. It reads the opening tag as quotedname="value"pairs and accepts only the ASCII whitespace XML and HTML share in the opening and closing tags. Element names must end at ASCII whitespace,/or>, and anyname=holding a non-ASCII character refuses. Every scan is still linear, andDEPTH_RULEShashes the new patterns.test/review-planner-misreads.test.ts: twelve new "keeps the SVG code" rows plus a positive control (a style comment, CDATA and quoted attributes keep a chart a drawing). Each batch failed on its parent commit and passes after its fix (ac0fa9e, 8ad07db, 6abe506).lib/review-depth.ts. On 62,805 unique SVG files (21,658 with a style element), every verdict matches main at 4bbad24. The planner over the last 100 first-parent main commits changes no depth, class or risk class.docs/review-policy.mdand a changelog fragment describe the rules.Proof
On main at 4bbad24,
svgDrawingreturns true for each shape (~/.capy/work/gstack/gst940-repro.ts,~/.capy/work/gstack/gst940-r2.ts). The test commits fail before each fix and pass after it.Issues
Fixes GST-940 (Capy issue). Follow-up: GST-997 (a prefixed
</q:style>still ends the walk early in inline SVG, and non-ASCII chart text before=now over-refuses).Review
Two rounds, then the granted fix-check and native rebind. Pass 1's red-team finding (the quoted
>) was fixed in pass 1. Round 2's red-team#1 (Unicode space) and targeted#1 (non-ASCII prefix) were fixed under the grant.Review-loop exception: accepted by GStack Minder (GSTA-36) 2026-11-02 via GSTA-36 message to GSTA-249: R51 grant after round 2: one scoped fix-check for red-team#1 and targeted#1 plus the native rebind; findings ship as open notes (fix-check at ee3908a, 1 finding)
Open notes (none blocks):
SVG_ATTRscans the whole text, so chart text like<text>α=0.05</text>oraria-label="Größe=10"now keeps a chart SVG code. No corpus file changed. Tracked in GST-997.SVG_STYLE_CLOSEaccepts any</prefix:style>, so a mismatched</q:style>ends the walk while an HTML parser keeps reading CSS. A standalone .svg is a fatal XML error. Tracked in GST-997.<style scoped>and unquoted attributes on the style tag now refuse. No corpus file changed.failed(stale patch id), not a finding.