Repository navigation
v1.93.34.0 test: docsync fault replays and the runShadow deadline test fit loaded remote VMs (GST-1103) - #3896
Merged
Merged
Conversation
…d remote VMs (GST-1103) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
…s (GST-1103) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Docsync fault wrappers now take a budget derived from the replay count, and the runShadow deadline tests leave room for a loaded VM.
Before/after as text
CALLBACK_TEST_MS) instead of Bun's 5 second default.(replays + 1) × 30 sfromcallbackBudgetMs(), so the outer limit always covers the inner ones.test/autoplan-shadow.test.tskeep the same assertions (a retry stops at the deadline; a slow call is cut off) with wider gaps between the delays, the deadline and the bound.Why
Remote pregates on loaded VMs went red in these files while the code under test was fine (GST-1103). The GSTA-234 remote log shows the deadline-retry case finishing in 2,558 ms against a 2,400 ms bound, and the fault-callback replays hit Bun's 5 second default under load. With 8 busy loops on 4 cores, main failed all 12 legacy-control replays; this branch passed them.
Blast radius
Test files, one test helper and a changelog fragment only; no product, gate or workflow code changes. The assertions still check the same behavior, only the time each test may take changed, and four targeted remote runs plus one selected-tier remote gate passed with 0 failures.
Approvals
No approvals recorded for branch capy/gst1103-docsync-timing.
Summary
Docsync fault-callback tests get per-replay limits and wrapper budgets derived from the replay count,
docsync-report-interfacegets the same limits, and the runShadow deadline tests get margins that hold on a loaded VM.Documentation
Status: current. The change only raises test timeouts, and no authored doc goes stale.
Scope: base f1cbdbb..HEAD 766510b on capy/gst1103-docsync-timing: 7 committed files (6 tests plus changelog.d/capy-gst1103-docsync-timing.md). Nothing staged, unstaged or untracked. The changed tests were cross-referenced against the candidate's doc inventory, including docs/TEST_PORTFOLIO.md and docs/TESTING_INTERNALS.md.
Documentation health:
Coverage debt: none. The only new export is the test helper CALLBACK_TEST_MS/callbackBudgetMs, which is not public surface.
Diagram drift: none.
Test Coverage
The changed tests are the coverage:
test/docsync-fault-interface{,-legacy,-faults}.test.ts,test/docsync-report-interface.test.tsandtest/autoplan-shadow.test.ts, with the shared limits intest/helpers/docsync-fault-callbacks.ts.Pre-Landing Review
REVIEW_LOOP: passes=1 blocking_found=0 deferred=0 noted=0 fixed=0 scope=frozen
Eval Results
None; this change touches no prompt or skill text.
Scope Drift
None.
Issues
ISSUE_LINKS: none. Tracked as GST-1103.
Verification Results
scripts/ubicloud/pregate-remote.sh, us-east-a2) on tree ed76b500: three runs of 51 tests, 0 failed each.TODOS
None.
Test plan
bun test --timeout=30000over 5 files): 51 tests ran, exit 0.gstack-pregate --stage tests --remote): 3,491 tests, 0 failed on tree 9e6496a2.