Repository navigation
v1.94.4.0 captain docs: plan-first rule matches R65 (no plan review for bug fixes) - #3908
Merged
Merged
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
The eager-loaded captain and Capy gstack skills grew past their context-budget ratchet ceilings (captain 6576 > 6551, capy/skill/gstack 5367 > 5315). Shorten the sentence in both, drop the duplicate bug-fix clause from the Capy skill's Plan first bullet, and remove the stale 'short run, not no run' clause from docs/captain.md that contradicted the new rule. The test now asks each copy for --kind fix and --kind feature. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… repro or failing test) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…failing test written first) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The Capy gstack skill's plan-first rule now follows R65: bug fixes are exempt from plan review and carry a repro on current main or a failing test written first; features get the lean run. (Image render failed on this machine:
PR_SHOTS_RENDER_FAILED, so this is the text version.)Before/after as text: The Capy gstack skill's plan-first rule now follows R65: bug fixes are exempt from plan review and carry a repro on current main or a failing test written first; features get the lean run
The same wording lands in captain/SKILL.md.tmpl (and its generated SKILL.md), captain/templates/CREW.md, captain/templates/brief.md and docs/captain.md.
Why
Build E (#3897) made
gstack-autoplan next --kind fixprintAUTOPLAN: not needed (bug fix; R65)and made--kind featurerun one lean reviewer. Five copies of the plan-first rule still told lanes that "every other fix gets a one-round, eng-only plan", so a lane that read them would plan work the tool now skips. Now every copy says the same thing. A bug fix is exempt (the brief's reason isbug fix (R65)) and its PR carries the proof.Blast radius
Only prose changed, in two eager-loaded skills, two crew templates and one doc. No code reads the brief's
Plan:line. The eager skills stay under their context-budget ceilings: test/context-budget-ratchet.test.ts passes at 59bbd14, and it was the check that went red at 9911da7 before the wording was trimmed.Approvals
Summary
Plan-first wording in the captain and Capy skills, the CREW and brief templates and docs/captain.md now matches R65. The wording was trimmed to fit the context-budget ceilings, and two review rounds tightened it. Bug fixes are named as exempt, proof means a repro on current main or a failing test written first, and the phase order is scoped to the full run.
Test Coverage
test/captain-skill.test.ts checks every copy for
--kind fixand--kind featureand rejects the old "one-round, eng-only plan" phrase. Focused lane: 28 pass, 0 fail (context-budget-ratchet, captain-skill, parity-suite, captain-brief).Pre-Landing Review
Pass 1 (full depth) had no specialist or red-team findings. The adversarial voice raised 4 notes; 3 were labeled CRITICAL by the collector and fixed in caa17fc. Pass 2 had no specialist or red-team findings; one adversarial note was fixed in 5ecc503 under the granted fix-check, which found nothing. The outside voice (openai/gpt-6.1-sol) and the targeted reader found nothing in any round.
REVIEW_LOOP: passes=2 blocking_found=5 deferred=0 noted=0 fixed=0 scope=frozen unrecorded=5 ledgers_read=4 fix_checks=1 dispatches=4
Review-loop exception: accepted by GStack Minder 2026-11-03 via approval a-0c5c8ef7158a: standing grant, GSTA-258 builds, 2026-11-03 (fix-check at 5ecc503, 0 findings)
Gate edits: none detected (GATE_SCAN tagged=0)
Review notes
Plan: exempt: bug fix (R65), so a lane givenPlan: requiredcould apply that exemption to itself. The controller should own that line.bug fix (R65).--kind fixwrites no record, so the label is the lane's own call.Eval Results
evals: none affected (eval:select at origin/main: no behavioral probes, no quality judges).
Verification Results
Remote pregate at tree a2ec08439d33 (head 59bbd14): 18973 tests, 0 failed, $0.11. macos-named-regressions and windows-smoke cleared from CI runs 41568175095 and 41568175036.
gstack-pregate verify: ok.Documentation
Status: current. The R65 plan wording is consistent across every authored copy, so no doc edits were needed.
Scope: the 8 committed files in base 5192908..head 59bbd14 (none staged, unstaged or untracked), plus related docs: capy/skill/gstack/captain.md, docs/unattended.md and autoplan/DRIVER.md(.tmpl). I checked the wording against bin/gstack-autoplan and lib/autoplan-lean.ts, and searched the authored docs for the retired 'one-round, eng-only plan' and short-run fix recipe.
Documentation health:
--kind fix/--kind featurebehavior.Coverage debt: none found. Diagram drift: none, because no diagrams are affected.
Test plan
Issue: GST-1139 (follow-up to reports/GSTA-258-E-decisions.tsv row 8). The crew's own CREW.md copy is GStack Minder's to update.