Repository navigation
v1.94.35.0 fix(contracts): run gstack-skill-contract through the host-resolved bin path (GST-1088 lane B follow-up) - #3957
Conversation
…locks for /investigate, /review, /qa, /verify (GST-1088 lane B) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…s; bare gstack-skill-contract name until lane A ships it Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…llows the small-diff skip (review fix round) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… stop rules (Step 11 voices) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…CKER_SHIPPED flag Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This reverts commit cc1539c.
… qa parity cap Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… ships, and re-pin /review by the measured 240 bytes Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…check have landed Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…in path The Done-means check/waive sentence named a bare gstack-skill-contract, which a standard install does not put on PATH (fix-check finding on #3909 at 58aeee7). Render it through ctx.paths.binDir like every other gstack bin, with a failing-first test across every host. Re-pin /review by the measured +56 skeleton bytes and +24 chars per non-Claude host render. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…-1088-lane-b-bin-path Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # investigate/SKILL.md # review/SKILL.md # scripts/resolvers/contract-done-means.ts # test/fixtures/skill-md-size-allowlist.json # test/helpers/carve-guards.ts # test/skill-descriptions.test.ts
|
😎 This pull request was merged. |
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
E2E Evals: ✅ PASS14 executed, 0 reused rule/judge records | 0 manual accepted (unscored; no score-cache credit) | $5.44 rule/judge cost | reconcile exit: 0 Profile: pr / mode Rule and judge shards
Fail-closed reconciliationSliced lane: planner → duration-packed executors → fail-closed report. Behavior cases run a pre-registered 3-trial panel (PASS at 2/3 with no contract violation); a PASS 2/3 is shown with its failed trial, never as a clean pass. Reused results retain their original provenance and expiry. Dispatched narrow screen (gstack-ship-queue ready --screen) of merge commit |
…-1088-lane-b-bin-path Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # test/fixtures/skill-md-size-allowlist.json
What changed
The "Done means" list in /investigate and /review now runs the contract checker through gstack's own bin folder, for example
~/.claude/skills/gstack/bin/gstack-skill-contract checkon Claude Code, instead of a baregstack-skill-contract.Before/after as text: The Done means list now runs the checker through gstack's own bin folder instead of a bare command a standard install doesn't put on PATH
Why
A standard install doesn't put gstack's bin folder on PATH, so an agent that followed the list got "command not found" when it tried to record a waiver. The fix-check on #3909 at 58aeee7 found it, and it would skew GST-1089's contract adherence numbers if it shipped into the after pin. Every other gstack command in a skill already renders through the host-resolved bin path; this sentence now does too.
Blast radius
One sentence in two generated skills changes, on every host. Each host gets its own bin path from
ctx.paths.binDir(~/.claude/skills/gstack/binon Claude Code,$GSTACK_BINon hosts that resolve it at run time). No other wording moves. The waiver parser (lib/skill-contract.ts:289) is unanchored, so a waive call through the full path still records the waiver.Approvals
Merging main at 1ccab0d ran under GStack Minder's rule 19 grant (GSTA-36), relayed by the lane B parent. This is a bug fix with a failing test written first, so it took no plan approval (fix-lane exemption, R65).
APPROVALS_RENDER: redacted (repository visibility public); gstack-approvals list shows the full record
Summary
scripts/resolvers/contract-done-means.ts:renderDoneMeans(contract, binDir, checker)renderscheckandwaiveasbinDir + '/gstack-skill-contract …';generateContractDoneMeanspassesctx.paths.binDir.test/skill-descriptions.test.ts: a new test checks every host in HOST_PATHS for /investigate and /review. It failed before the fix (111 pass, 1 fail:investigate on claude: ... must run ~/.claude/skills/gstack/bin/gstack-skill-contract check) and passes after.test/helpers/carve-guards.ts/reviewmaxSkeletonBytes: 60,014 → 60,070 (+56)test/helpers/carve-guards.ts/reviewmaxSizeRatio: 1.3283 → 1.3288 (union 144,203 / baseline 108,523 = 1.328778)test/fixtures/skill-md-size-allowlist.jsongstack-review: agy 104,728 → 104,752, codex 104,251 → 104,275, copilot 104,309 → 104,333, cursor 122,781 → 122,805, factory 126,554 → 126,578, gemini 104,131 → 104,155, kiro 122,605 → 122,629, opencode 123,403 → 123,427, slate 122,693 → 122,717 (+24 each)test/fixtures/review-pins/,scripts/harness-pins/) hold none of them.Test Coverage
Coverage: deterministic (each of 3 changed runtime files has a changed test naming it; no audit reader).
Pre-Landing Review
Pre-Landing Review: 5 issues — 0 auto-fixed, 0 asked, 0 deferred, 5 noted
REVIEW_LOOP: passes=1 blocking_found=0 deferred=0 noted=1 fixed=0 scope=frozen ledgers_read=1 dispatches=1 (plus one native adversarial pass, 4 findings, all noted)
Gate edits: 7 listed, 7 read, 0 findings — 0 kept, 0 restored, 0 open. The listed hunks are the re-pins above (
test/helpers/carve-guards.ts,test/fixtures/skill-md-size-allowlist.json) and the new test.Review notes
Below the blocking floor; recorded here and not fixed in this PR.
lib/skill-contract.ts:475) anddocs/skill-routing-and-contracts.md:100still name a baregstack-skill-contract waive. Two reviewers found it. A dropped waiver already counts as a miss, so no test fails and no data is lost. It's a lane A follow-up.checknames no--transcript/--skillflags, so running it as written exits 2. That wording came from v1.94.22.0 feat(skills): when-to-use descriptions, wider triggers and contract blocks for /investigate, /review, /qa, /verify (GST-1088 lane B) #3909, and this fix changes no other wording.$GSTACK_BIN, an inline code span isn't run with the runtime prelude. Every other inline bin mention behaves the same, and these hosts have no contract hook.Issues
Refs #3909
Eval Results
bun run eval:select --base origin/mainselects the dependents ofscripts/resolvers/contract-done-means.ts; they run as this PR'sready --screenpaid screen.Documentation
Status: current. No documentation edits were needed or made (read-only mode).
Scope: base 1ccab0d..head 3129fe8 on capy/gst-1088-lane-b-bin-path. No staged, unstaged or untracked content. The 7 committed files are the changelog fragment, investigate/SKILL.md, review/SKILL.md (both generated), scripts/resolvers/contract-done-means.ts, test/fixtures/skill-md-size-allowlist.json, test/helpers/carve-guards.ts and test/skill-descriptions.test.ts. Discovery covered the candidate's authored doc inventory, with focused source verification of the changed contract.
Documentation health
gstack-skill-contractmentions are a command synopsis, not run instructions, so there is no contradiction. It was verified by grep, not a full read.Coverage debt: the optional note on how to reach the checker (see decisions) is a gap only reported, not filled. There is no diagram drift.
Test plan
bun test test/skill-descriptions.test.tsfailed 111/1 before the fix and passes afterbun run typecheck: 0 errors;bun run gen:skill-docs --dry-run: 0 stale