Repository navigation
ship finish: a Godot UID sidecar added after review binds with no reader; base-declared test_code (GST-1604) - #4063
Merged
Merged
Conversation
…der; base-declared test_code globs (GST-1604) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
…spawns fail on windows-latest, run 42205201312) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: p1/red-team#1 reader=red-team Review-Finding: p1/specialist-batched#1 reader=security Review-Finding: p1/specialist-batched#2 reader=testing Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…aths never declared test code) Review-Finding: v1/outside-voice#1 reader=outside-voice Review-Finding: v1/outside-voice#2 reader=outside-voice Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…never a scene that references the script (GST-1604) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…604) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…D (GST-1604) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ST-1604) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
3 tasks done
…ecar Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # docs/ship-policy.md # lib/ship-policy-keys.ts # lib/ship-policy.ts
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
finish now routes a Godot UID sidecar added after review with no reader, and the base can declare its own test globs.
Before/after as text: finish now routes a Godot UID sidecar added after review with no reader, and the base can declare its own test globs
Why
founderstar#611 committed
tests/cutscene_check.gd.uidafter the owner's granted fix-check, and no finish route took it, so a one-line random id cost another fix-check or a fresh /ship. finish now proves such a sidecar and routes it with no reader, and a base policy can name its GDScript test files undertest_codeso they get the scoped test reader instead of a behavior route.Blast radius
The change touches finish's route (lib/ship-release.ts, lib/ship-mechanical.ts), the patch classifier (lib/ship-patch.ts), the policy keys, the receipt's mechanical list and the pr-body template. It is safe because every proof failure keeps the old behavior route and prints a
ROUTE_SIDECAR_REFUSED:reason, which the focused lane exercised (script ran: 233 tests, 0 fail, at 265d868 and again at f8f220e after the base merge).Approvals
Approved: yes (record r-e0fcc5d4dce0). The full approval record stays private: this repository is public or its visibility is unknown.
Summary
Godot 4 writes a
<file>.uidbeside every script, and a lint step can ask for one after review is done. Before this PR, finish routed that file as behavior and stopped the ship. finish now proves each such.uid(added after review, beside a reviewed or exception-accepted regular file, one canonicaluid://<id>line, mode 100644, no other declaration of the same UID in the tree, nothing excluded from review) and counts it assidecar=<n>onROUTE:. Anything else keeps its route with a refusal reason. The receipt lists each proven sidecar and refuses a PR body that leaves one out. The new base-onlytest_codepolicy key lets a project declare test globs that the built-in globs miss, and a declared glob never matches.gstack/or.github/. The review rounds hardened the proof (utf8 path decoding,readers.forbid_paths, UID uniqueness) and narrowed the UID holders to real declarations. The Windows curation list excludes the new test file, since bin shebang spawns fail on windows-latest (run 42205201312).Test Coverage
Coverage: 87% (13 of 15 paths), from the Step 7 audit (audit only, no tests written by the audit).
Tests: test/ship-uid-sidecar.test.ts is new, with 10 tests, failing first on main with the #611 STOP.
Gaps: the docsFresh
test_codebranch in lib/ship-release.ts has no test (review note below), and the stack-parent refusal path prints no reason (review note below).Tests ran: focused 233
Pre-Landing Review
Pass 1 (full panel, p1) found 3 issues, all fixed in b0d3849: the sidecar path decode used latin1 instead of utf8 (red-team), the sidecar proof ignored
readers.forbid_paths(security), and docsFresh dropped a declaredtest_codepath (testing). Pass 2 (p2, range 7e7b248) left 1 note. The Step 11 outside voice and adversarial pass (v1, native plus openai/gpt-6.1-sol) found 2 CRITICAL issues, both fixed in c25c5de: a declaredtest_codeglob could match.github/or.gstack/paths, and the proof did not check that the UID was unique in the tree (the adversarial reader raised both as duplicates). It also left 3 notes. Fix-check fc1 (c25c5de) found nothing. Fix-check fc2 (7f0ecb8, the UID-holder narrowing) left 1 informational note: CRLF copies of a sidecar are not caught as holders. Fix-check fc3 (b0d3849..265d868) found nothing. After the owner's rule-19 merge of main (f8f220e), fix-check fc4 read only the conflict resolution in docs/ship-policy.md, lib/ship-policy-keys.ts and lib/ship-policy.ts, which keeps both this PR'stest_codekey and #4065'sci_record_timeout_skey, and found nothing. Its review-log row is recorded with range b0d3849..f8f220e, so finish counts fc3's and fc4's reads together. Two tooling workarounds carried fc4, both disclosed here: the planner was run with--last full(as GSTA-337 did for fc2 and fc3), because after a fix-check it plans a stop even with a recorded grant; and the fc4 review-log row was logged a second time with range b0d3849..f8f220e after the first row (range 265d868) was not counted, since finish binds only a row whose range starts at the reviewed tree. fc4's reader saw only the merge resolution, so that row stands for fc3's and fc4's reads combined, not for one reader of the whole range.REVIEW_LOOP: passes=2 blocking_found=2 deferred=0 noted=5 fixed=5 scope=frozen ledgers_read=9 fix_checks=4 dispatches=8
Review-loop exceptions: the owner (GStack Minder, 2026-11-06, via GSTA-36) granted four scoped fix-checks after the round cap: fc1 (approval a-e50129433f76), fc2 on the 7f0ecb8 narrowing (a-739f87c51600), fc3 on
git diff b0d3849..HEADafter the owner's own pr-body template order (a-533fa23de622), and fc4 on the merge resolution after the owner's rule-19 merge (a-da5b8ee99f78).Gate edits: none detected (1 listed, 0 read)
Outside review: pass (openai/gpt-6.1-sol, v1). Its 2 blocking findings were fixed in c25c5de.
Review notes
Below the blocking floor (advisory, informational, test-gap or wording items); recorded here and not fixed in this PR.
lib/ship-release.ts:432docsFresh now carries a declared test_code path as a test, but no test exercises that branchlib/ship-release.ts:334under a landed stack parent the child's own .uid files are never candidates and print no ROUTE_SIDECAR_REFUSED reasonbin/gstack-ship-receipt:274the receipt refusal for an unlisted sidecar line still points at finish's MECHANICAL: lines, not UID_SIDECAR:lib/ship-sidecar.ts:52entry() runs ls-tree without --full-tree, so finish run from a subdirectory refuses every sidecar with a misleading reason (safe failure)lib/ship-sidecar.ts:59CRLF copies of a sidecar are not caught as UID holdersExploratory QA
Target:
gstack-ship-release finishsidecar routing anduidSidecars(lib/ship-sidecar.ts), on isolated temp fixtures only. Checkpoint 002 failed before the fix:scripts/menü.gd.uidrouted as proven beside an excluded sibling (the p1 red-team finding, replayed). Checkpoints 003 and 004 passed after the utf8 fix. Verdict: pass, with no open required checks. Limit: the 300 s smoke budget expired before revalidation, so 003 and 004 ran as revalidation with --timeout-ms.Design Review
No frontend files changed — design review skipped.
Eval Results
Evals not run in this /ship: the 113 selected behavioral eval probes for this diff were left to the release gate.
Review bot comments
No review bot comments.
Scope Drift
Scope Check: CLEAN
Plan Completion
No plan file: this is a bug fix with a failing-first test (test/ship-uid-sidecar.test.ts fails on main with the #611 STOP).
Issues
Refs p1/red-team#1
Refs p1/specialist-batched#1
Refs p1/specialist-batched#2
Refs v1/outside-voice#1
Refs v1/outside-voice#2
Verification Results
Step 8.1 obligations: 1 PASS (the #611 repro binds with no reader at 265d868, test/ship-uid-sidecar.test.ts), 0 FAIL, 0 BLOCKED. The full free suite was not run locally; CI at f8f220e carried it (run 42222590559, green).
TODOS
No TODO items completed in this PR.
Documentation
Status: current. No documentation edits were needed.
Scope: base 63489d0, head f8f220e on capy/gst-1604-uid-sidecar, with no staged, unstaged or untracked content. Reviewed the changed hunks of the committed docs (
docs/ship-policy.md,docs/troubleshooting.md,ship/sections/pr-body.mdand its.tmpl, and thechangelog.dfragment) againstlib/ship-sidecar.tsandlib/ship-policy.ts. The.uidregex, theROUTE_SIDECAR_REFUSEDreasons and thetest_codekey match the code.Documentation health:
docs/ship-policy.md [Current] (test_code row, UID sidecar section match code)
docs/troubleshooting.md [Current] (route-sidecar-refused entry matches code)
ship/sections/pr-body.md + .tmpl [Current] (in sync)
changelog.d/capy-gst-1604-uid-sidecar.md [Current] (not modified)
docs/review-policy.md [Current, with a gap] (see debt)
TODOS.md [Skipped] (not touched in ship-owned mode)
Documentation coverage:
UID sidecar route: reference ✅ (ship-policy.md, troubleshooting.md), how-to ❌, tutorial ❌, explanation ✅ (ship-policy.md section)
test_code key: reference ✅, how-to ✅ (inline example), tutorial ❌, explanation ✅
Documentation debt: docs/review-policy.md Bounded post-review edits lists the bounded kinds but not the sidecar route or test_code (common gap; the explanation quadrant would fill it). One ambiguous clause in docs/ship-policy.md about a sibling declared test_code needs author confirmation.
Diagram drift: none found.
Test plan
bun testover the 10 sidecar, route, policy, size-ratchet, tripwire, shard and Windows workflow files, launch vars unset, TMPDIR=/var/tmp/gst1604-lane): 233 pass, 0 fail at f8f220e (tree 97749931c04f)bun test test/parity-suite.test.ts: 2 passbun run test): carried from CI at f8f220e (run 42222590559, 1610 files; the 111 remote-gate files and the macos-named-regressions and windows-smoke lanes cleared from runs 42222590559 and 42222590562). Every pull_request check is green at f8f220e: 33 passed, 0 failed, 12 skipped. The earlier shard 10/8 failures (runs 42207455885 and 42217554157) were the test/ship-queue-land-direct.test.ts isolation bug that GST-1613 (63489d0) fixed on main; this branch picked it up in the merge.gstack-ship-release acceptat f8f220e carried the tests lane (EVIDENCE FRESH, run 42222590559) but never exited 0: its final pregate rerun resets the macos-named-regressions and windows-smoke clears and stops. Both were re-cleared from runs 42222590559 and 42222590562, andgstack-pregate verifypassed for tree 97749931c04f before the receipt write.mutation lock > two concurrent add-eventsin the settings hook, which this PR does not touch. It was not rerun at that tree and has no flaky-ledger entry, so it is unconfirmed as a flake; the check is green at f8f220e.🤖 Generated with Claude Code