Repository navigation
Make the behind= trailer and rebase rules agree across gstack docs (GST-2136) - #4224
Merged
Merged
Conversation
…ST-2136) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
…te (GST-2136) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…gelog fragment (GST-2136) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents now get one answer when gstack's install check says their copy is behind (run the fix it prints before the next workflow), and the unattended docs now say a branch whose base moved is merged, never rebased. That keeps crews on current gstack and keeps reviewed branches intact.
What changed
behind=1or more means run the trailer's fix before the next workflow. Two things still hold the checkout where it is: a pin with a recorded reason (astale=<h>h (pinned: <why>)note, or afix:startingunset GSTACK_CAPY_, which is skipped while the reason is recorded), and an install that was refused (upgrade skipped: … (<CODE>)). Files: capy/skill/gstack/SKILL.md, capy/skill/gstack/lane-card.md, docs/capy-install.md, docs/troubleshooting.md, a comment in bin/gstack-capy-install, a test comment in test/capy-skill-wrapper.test.ts, and the UPGRADE_SKIPPED fix string in lib/result-codes-capy.ts.Why
The Capy skill said both "run the fix" and "
behind=alone is informational" about the same trailer, so most lanes took the second reading and kept working on an old gstack. FOUN-35's audit found 113 of 150 follow-up trailers at the same or an older revision than the first one. The rebase wording was a second contradiction: docs/unattended.md let a slot call rebase a reviewed branch, while ship-policy.md says to merge.Blast radius
Only prose changed, plus one comment, one test comment and one fix string. No runtime logic moved, so every install, upgrade and pin behaves as before. The pin case was checked against bin/gstack-capy-session L139-176 and L229-241 (file:line read): a reasoned pin still holds, because the docs now tell agents to skip the
unset GSTACK_CAPY_fix while a reason is recorded. The Drive copy of the Capy skill does not update itself, so the owner recopies it after merge.Pre-Landing Review
No blocking issues remain. The one blocker (outside voice, openai/gpt-6.1-sol: following the new rule would unset a deliberate pin under 24 hours old) was fixed in 8e64a8a. A scoped fix-check the Captain granted past the round cap reviewed that fix and found nothing blocking.
Gate edits: none detected (1 listed, 1 read).
Outside review: openai/gpt-6.1-sol at 0e737b3 found 1 blocker, now fixed and fix-checked at 8e64a8a.
Review notes
Below the blocking floor; recorded here and not fixed in this PR.
bin/gstack-capy-session:244The stale message still says "run the fix before the first workflow", while the docs now say "next workflow". Tests at test/capy-skill-wrapper.test.ts:797 and :1226 pin the string.capy/skill/gstack/SKILL.mdstep 2 The "behind=1 or more" rule does not say it applies only togstack: ok <revision> for=<skill>trailers, notfor=noneones.capy/skill/gstack/SKILL.mdstep 2 The rule does not say whether the fix runs once per session or once per workflow.docs/unattended.mdThe closing sentence names only a plan-named rebase and drops the/modernizedisposition the bullet above it allows.capy/skill/gstack/SKILL.md:13The skip clause for afix:startingunset GSTACK_CAPY_does not restate its condition (a recorded reason) as a check the agent runs; docs/capy-install.md:143 does.capy/skill/gstack/SKILL.md:13Step 2's reason list names GSTACK_PIN_REASON and gstack.pinReason, not--revisionorgstack.contributor, which the wrapper also counts.capy/skill/gstack/SKILL.md:13The skip clause is not limited to ok trailers. Afail revisiontrailer with AUTO_UPGRADE=0 and a recorded reason would skip its only fix; this fails closed.capy/skill/gstack/SKILL.md:13Step 2 now says a thread older than a day reruns the check before its next workflow, dropping "once its last check is over 24h old".Test Coverage
No changed executable paths, so there are no coverage gaps.
Eval Results
No paid evals ran. eval:select picked dependency-derived behaviors from a bin comment and a lib fix string, and that selection was over the $10 per-PR cap.
TODOS
No TODO items completed in this PR.
Documentation
Status: current. No documentation edits were needed; the branch's own doc changes are consistent and complete.
Scope: the 9 committed files from base 324135d to head 8e64a8a (GST-2136): capy/skill/gstack/SKILL.md, capy/skill/gstack/lane-card.md, docs/capy-install.md, docs/troubleshooting.md, docs/unattended.md, changelog.d/fix-behind-trailer-and-rebase-docs.md, plus the doc-bearing source bin/gstack-capy-install, lib/result-codes-capy.ts and test/capy-skill-wrapper.test.ts. I grepped the whole repo's authored .md and .tmpl files for behind=, stale= and rebase wording, and checked crew/docs/recommended-harness.md and docs/ship-policy.md as cross-references.
Documentation health:
Coverage debt: no new public surface. The behind= rule has reference coverage in docs/capy-install.md and docs/troubleshooting.md and how-to coverage in the Capy skill and lane card, so there are no gaps.
Diagram drift: none. No diagrams reference the changed entities.
Test plan
Agent notes
Refs GST-2136
Approvals
Approved: yes (record r-22f09787b801). The full approval record stays private.
Plan: exempt: bug fix
Plan check: exempt bug fix
REVIEW_LOOP: passes=2 blocking_found=1 deferred=0 noted=5 fixed=0 scope=frozen unrecorded=1 ledgers_read=4 fix_checks=2 dispatches=3 est_input_tokens=13655
Gate edits: none detected (1 listed, 1 read).
Review-loop exception: accepted by Captain GStack Minder (GSTA-36) 2026-11-09 via a-8336e5886c5d: one scoped fix-check past the round-2 cap for p2/outside-voice#1, a pin with a recorded reason holds (review_loop_grant 8e64a8a on #4224, Captain grant a-7b7ca6b68359) (fix-check at 8e64a8a, 4 findings)
Review: pass 1 light (specialist-batched, no findings; one core note at bin/gstack-capy-session:244). Pass 2 scoped after a CI repair (red-team and fix-check, no findings). Step 11 at 0e737b3: adversarial-native 4 Low notes, outside voice openai/gpt-6.1-sol 1 blocker (p2/outside-voice#1). Granted fix-check at 8e64a8a (p3): 4 INFORMATIONAL, 0 CRITICAL. Step 11 was not rerun after the fix-check: its plan listed no voices (ADVERSARIAL: skipped (review plan)).
C8 declined: the sentinel polling in CLAUDE.md and AGENTS.md is right for Claude Code, where a detached eval has no callback. eval:watch is retired, and the only other mechanism,
bun run scripts/eval-bg.ts status, is already named there.Classifier: DOCS_ONLY: no (bin, lib and test files changed), so CI ran in full.
Paid evals: none run. eval:select's selection was over the $10 per-PR cap.
gstack: ok 1.98.0.0 for=ship (behind=1 (latest: 1.98.0.0); fix: bash /home/user/.capy/drive/user-garry-tan/skills/gstack/scripts/install.sh --for ship)