Repository navigation
The lander must accept each owner-approved gate change before a PR merges (GST-2491) - #4304
Merged
Merged
Conversation
…p (GST-2491) An unattended /ship logs every gate finding open and nothing could close it, so a PR with an owner-approved gate change could never finish. gstack-approvals gate records the owner disposition outside the run; it closes only that fingerprint on a review row whose range holds the head, and finish, the receipt, the PR body and READY all carry it. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… a dispositioned gate finding (GST-2491) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… rest of /ship (GST-2491) A disposition now names the finding's gate_id as well as its fingerprint, so a later loosening of the same line stays open. gstack-review-read shows a closed gate finding as kept with the disposition's approval id, so the existing --blocking-open, --gate-open, draft and Gate edits rules carry it without prose changes, and an unreadable approval record applies no disposition instead of failing the reader. Review-Finding: p1/red-team#1 reader=red-team Review-Finding: s11/outside-voice#1 reader=outside-voice Review-Finding: s11/outside-voice#2 reader=outside-voice Review-Finding: s11/adversarial-native#1 reader=adversarial-native Review-Finding: s11/adversarial-native#2 reader=adversarial-native Review-Finding: s11/adversarial-native#4 reader=adversarial-native Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ng entries (GST-2491) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ng (GST-2491) Land and a new read-only verify --pin re-derive the dispositions the approval store applies at the pin and merge only with --accept-gate-disposition for each one. The gate writer refuses while any worktree holds an open /ship run on the branch, under a lock; a row counts only in the writer's full shape with its digest; receipt write needs --body when a disposition applies; ready and land cross-check the receipt and body against the store. Supersedes #4299. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…GST-2491) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… disagrees at merge (GST-2491) The receipt always carries gate_dispositions (an empty list when none apply) and write refuses on an unreadable store or a git error. Land, verify and ready refuse a receipt id the merge-time store lacks, naming the likely wrong state root or mirror, and a field-less receipt beside an applied row. A git ancestry error while deriving dispositions refuses instead of reading as not applied. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…expect the receipt to end with gate_dispositions (GST-2491) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
…un's ended lease stop blocking it (GST-2491) Review-Finding: s11/outside-voice#3 reader=outside-voice Review-Finding: s11/outside-voice#2 reader=outside-voice Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An unattended /ship can now finish a PR whose gate change the owner approved, and the person who lands the PR has to accept each such approval by id before it merges. This keeps crews shipping without a human in the loop while the merge decision stays with a separate actor, which is what Founderstar's lander asked for.
This supersedes #4302 and #4299 and builds on both. #4299 added
gstack-approvals gate, the owner's recorded answer that closes one gate finding; credit to it for the recorder, the matcher and the disclosure lines. #4302 added the lander's acceptance,verify --pin, the writer hardening and the receipt's always-recorded set; credit to it for all of that. This PR carries #4302's head unchanged and adds the two fixes its last review found.What changed
gstack-ship-queue land --pinworks out the gate dispositions the approval store applies at the pin, prints each as aGATE_DISPOSITION:line, and merges only when the lander passes--accept-gate-disposition <approval id>for every one. It refuses withQUEUE_GATE_DISPOSITIONwhen one isn't accepted, when an accepted id names nothing, or when the receipt or PR body leaves one out, changes one or invents one. It never trusts the receipt for this.gstack-ship-queue verify --pr <n> --pin <sha> [--accept-gate-disposition <id>]...runs the same function as land, read-only, and exits 0 only when every disposition is accepted.gate_dispositionsis always written, as[]when none applies, so a merger reading another state root, or a store that lost a row after the receipt, refuses instead of reading as nothing to accept.readyprints the dispositions it works out and refuses the same mismatches.gstack-approvals gaterefuses while a /ship run is open on the branch in any worktree, checks and appends under a lock in the git common dir that /ship's preflight also takes, and refuses--gate-id undefined.source: gate, the store's own branch and a digest over those fields. The digest catches edits; it isn't authentication.gstack-ship-receipt writerefuses while a disposition applies at HEAD unless--bodycarries each line.Why
A lane runs as the same user as everything else on its machine, so it could write a disposition row itself. The real boundary is the separate actor who lands the PR: the hardening makes casual self-approval fail, and the lander's explicit acceptance authorizes the rest.
Blast radius
Only PRs with an owner gate disposition are affected; land, verify and ready print nothing new when the store holds none. A store that can't be read stops ready and land instead of reading as empty. A lander that merges through the REST API runs
verify --pinfirst.Test Coverage
test/ship-gate-dispositions.test.ts and test/ship-queue-land-direct.test.ts cover the writer, malformed rows, the receipt's disclosure and the lander's acceptance end to end. New here: a branch rewritten and garbage-collected so a recorded row's head is gone, where ready, verify, land and receipt write keep working with that row not applied; a pin missing from the clone refuses; a shallow clone refuses and says to deepen. test/gstack-ship-receipt-docs.test.ts now expects
gate_dispositionsas the receipt's last key.Pre-Landing Review
Review notes (below the blocking floor)
land --pinandverify --pinenforce--accept-gate-disposition. gstack runsmerge: direct, so this repository is not exposed; repositories on trains are.verify --pindoes not check that--pris numeric the waylanddoes.openRunleaves a live lease in the test run's shared GSTACK_LEASE_DIR.gstack-approvals rule) still refuse on any marker, so a parked run now blocks rulings but not gate dispositions.Test change: the two existing marker tests in test/ship-gate-dispositions.test.ts now open a live lease (
openRun) as well as writing the marker, because the fix counts a marker as an open /ship run only while its lease is open, the same test preflight uses; a marker alone now models a parked run, which a new test covers.Documentation
Status: current. The docs match the code and no edits were needed (read-only audit).
Scope: 28 committed files from base 0ead11c to head 144fc4e (9 commits); nothing staged, unstaged or new. Read in full: the docs/ship-policy.md gate-dispositions and acceptance sections and the landing-checks row, the docs/troubleshooting.md QUEUE_GATE_DISPOSITION and gate-finding-open-unattended entries, ship/sections/pr-body.md and its .tmpl, the changelog.d fragment, and the source behind them (bin/gstack-approvals, bin/gstack-ship-queue, lib/gate-dispositions.ts).
Documentation health:
Coverage debt:
gstack-approvals gate,gstack-approvals dispositionsandgstack-ship-queue land|verify --accept-gate-dispositionare documented only as reference (ship-policy and troubleshooting). No how-to or captain landing guide (docs/captain.md, captain/SKILL.md.tmpl) mentions the acceptance step yet; consider /document-generate for these.Diagram drift: none found.
Issues
Refs #4299
Refs #4302
Agent notes
GST-2491. Finish lane GSTA-523 (GStack Minder crew), successor to GSTA-518 and GSTA-520. Docs: docs/ship-policy.md#gate-disposition-acceptance, docs/troubleshooting.md#queue-gate-disposition.
Agent notes