Skip to content

Document approval classes in the ship policy guide - #4355

Merged
capy-ai[bot] merged 1 commit into
garrytan:mainfrom
ElNeMeR70:docs/ship-policy-approval-classes-4320
Nov 16, 2026
Merged

capy-ai[bot] merged 1 commit into
garrytan:mainfrom
ElNeMeR70:docs/ship-policy-approval-classes-4320

Conversation

@ElNeMeR70

Copy link
Copy Markdown
Contributor

Adds the ## Approval classes\ section to \docs/ship-policy.md\ (the target of the \ship-policy.md#approval-classes\ anchor linked from \docs/troubleshooting.md\ and $schema).

Documents:

@trunk-io

trunk-io Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

😎 This pull request was merged.

@capy-ai

capy-ai Bot commented Nov 14, 2026

Copy link
Copy Markdown
Contributor

Thank you for the steady stream of fixes. We limit contributors to 3 open pull requests at a time when several recent PRs haven't been taken, and you currently have more than that open here, so I'm closing this one for now. The missing section is still tracked in #4320, and if we use your text when we write it, we'll credit you as co-author. The limit lifts once 2 of your PRs in a row are taken. You're welcome to reopen this then, or keep commenting on the issue.

@capy-ai capy-ai Bot closed this Nov 14, 2026
@capy-ai capy-ai Bot reopened this Nov 15, 2026
@capy-ai

capy-ai Bot commented Nov 15, 2026

Copy link
Copy Markdown
Contributor

Sorry about the earlier close. We loosened the open-PR limit today: it no longer applies to anyone who has had a PR taken in the last 90 days, and your #4189 landed as #4219 with you credited. So this PR is back in review. Since it only changes documentation people read, it can be merged as it is once we've checked every link, command and field in it against main. We'll comment here with the outcome.

@capy-ai
capy-ai Bot merged commit 9e6a96c into garrytan:main Nov 16, 2026
104 checks passed
@garrytan garrytan mentioned this pull request Nov 17, 2026
capy-ai Bot added a commit that referenced this pull request Nov 17, 2026
- /autoplan's approval page no longer hides a reviewer's product objection behind "keep your direction". (#4431)
- Every skill that loads the shared preamble, on every host, now says to ask a question once and to check a file before handing it over. (#4383)
- The Captain manuals now name the `Failed or skipped:` and `Also changed:` lines that READY and lane reports carry. (#4432)
- gstack's shell locks hold again on Ubuntu 26.04, where `mkdir` reports success when another process won the race (GST-2247). (#4262)
- `test/gstack-lock-race.test.ts` runs the old pattern and the helper against a PATH shim that behaves like uutils 0.8.0 `mkdir`, so it runs on any runner image: the old pattern lets two of four racers win, the helper admits exactly one in each of 60 races and never overlaps across take, hold and release loops, and parallel `gstack-config` writers keep every key. (#4262)
- Windows Setup E2E now runs when `bin/gstack-lock.sh` changes. (#4433)
- Claude Code's skill list now says when to use each gstack skill, so Opus loads /review and /plan-eng-review when a request fits. (#4387)
- A pull request's merge head can no longer keep its `/ship` receipt without a full review. (#4365)
- `/ship` now counts review rounds per pull request, and the head that merges always gets a full review. (#4360)
- /ship's documentation audit no longer accepts a passing result when an earlier line from the same audit said "blocked". (#4434)
- /ship's documentation audit no longer spends an attempt when the audit child writes text after its result. (#4285)
- The README lists the two new guides, and the install doc counts its hooks right. (#4403)
- docs/releases.md now says the stable release cut treats a failed commit status as red and a pending one as still going, as it has since #4257. (#4436)
- /ship's `finish --docs-requested` now accepts a docs fix when the audit named the file with a line number. (#4437)
- Document the `.gstack/approval-classes.json` schema, `gstack-approval-classes` CLI commands, and owner approval citation format in `docs/ship-policy.md#approval-classes`. (#4355)
- `/eval-plan` now runs four result checks instead of leaving them to judgment. (#4384)
- The /review coverage-audit eval no longer fails a run that really read the source file when zsh stops a command line at an `echo ====` separator. (#4364)
- Sixteen in-repo documentation links reach their section again. (#4394)
- gstack agents now open every status report with what failed, what they didn't verify and what else they changed. (#4273)
- Two new short guides. (#4380)
- A skill you wrote whose contract still lists `check_after_last_edit` keeps the rest of its contract. (#4439)
- The ship policy guide now explains how to merge any pull request with `gstack-ship-queue land`, even in a repository with one maintainer. (#4377)
- /ship's test step runs a large unit suite on Linux. (#4426)
- Every skill that loads the shared preamble, on every host, now says never to print a whole environment, git config or process table. (#4382)
- Pull requests from /ship now open with at most three plain lines, and every merge lands as one commit titled with the PR title. (#4438)
- `gstack-pr-wait`, `gstack-ci-gate` and the release cut no longer call a commit green while a check on it failed. (#4257)
- `gstack-runaway` now says what a thread's cold and empty wakes cost, not just how many there were (GST-2770). (#4385)
- The optional Stop hook no longer checks for a test run after the last edit, and /verify asks for it in plain words instead. (#4428)
- /ship's test step says when it ran out of time, and you can set its budget. (#4429)
- The remote test command no longer puts every file on one command line. (#4429)
- The stable release no longer waits on the nightly Windows tests (GST-2815). (#4400)
- Ubicloud fan-outs can no longer overshoot the vCPU limit, and owners no longer delete each other's VMs. (#4430)
- hono is pinned to 4.13.16, which fixes five advisories the weekly OSV scan found in 4.13.13 (gstack#4406). (#4408)
- `package.json` overrides (#4408)
- `test/dependency-security.test.ts`: the lockfile floor check now covers `hono >= 4.13.16`. (#4408)
- The nightly Windows test run finishes again. (#4409)
- A short write-up checklist in ETHOS.md. (#4381)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: troubleshooting links ship-policy.md#approval-classes, which doesn't exist

1 participant