Repository navigation
Plan a trial of /ship without its separate conductor subagent (GST-3003) - #4456
Merged
Merged
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
…T-3003) Review-Finding: p1/outside-voice#1 reader=outside-voice Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
capy-ai Bot
added a commit
that referenced
this pull request
Nov 18, 2026
- A test, or a scratch repository in the temp directory, can no longer write approval rows into your real Capy Drive (GST-3027). (#4466) - An unattended /autoplan run on Claude Code no longer says the publication guard is off while it is on. (#4481) - A phase report written only in reasoning now gets a denial that says so and names the fix. (#4481) - `gstack-autoplan revise` no longer refuses a plan that the first `next` accepted. (#4470) - `revise --plan` with a different file now says the run follows that file. (#4470) - A second-model plan review in `/autoplan` is no longer reported as unavailable when it actually ran (GST-3051). (#4471) - The /ship conductor trial plan now lets case reverts that conflict with later code be resolved by hand in docs, tests and the planted file, so large pull requests can be cases (GST-3003). (#4460) - A locked plan for a trial of /ship without its separate conductor subagent (GST-3003). (#4456) - A driven /ship now runs each phase as one command, counts its calls, and stops itself at 100 minutes. (#4451) - /ship stops asking owners to clear two kinds of bookkeeping noise: base-side merge text and a reviewer's confirmation prose. (#4458) - A base merge that only touched base-side text no longer stops `/ship` finish for an owner's grant. (#4458) - A reviewer's confirmation prose no longer becomes a Critical finding that only an owner can clear. (#4458) - A CI run that passed only after its failed jobs were re-run is now marked wherever gstack reuses it. (#4473) - /ship reuses CI's passing test run when merging the base changed no file, and stops instead of quietly starting hour-long test runs or reviewing an empty diff (GST-3019). (#4461) - /ship on Codex no longer stops at the test coverage audit. (#4489) - A cold first-use check before an app build reaches its owner (GST-3025). (#4465) - `skill_prefix=true` now survives updates when gbrain is installed. (#4454) - The OpenClaw docs no longer send you to ClawHub, which held only April 2026 builds of office-hours, ceo-review and retro and no longer has gstack skills (the docs also said four skills while listing three). (#4454) - `gstack-issue-links` no longer reads other repositories' issues as gstack's. (#4454) - /ship's pre-gate finds the tests of a monorepo app that imports through its own `@/` alias. (#4464) - /office-hours explains why it recommends a mode. (#4450) - /office-hours keeps its 34 founder videos and essays out of the skill file. (#4463) - Two `gstack-owner-answers add` runs for the same answer no longer collide. (#4490) - A Captain can check an ask against the owner's earlier answers before sending it. (#4467) - `gstack-post` stops reading /ship's own receipt identifiers as phone numbers, so posting a /ship PR body no longer needs a confirm. (#4488) - GitHub release notes now list every change in plain words, with a link to its pull request. (#4390) - gstack's router no longer gives bug reports a special rule, so the model fixes a bug the way it would without gstack. (#4442) - /ship's review plan now sorts Swift and Xcode files by risk instead of sending every iOS PR to the full review panel (GST-3041). (#4469) - /ship's review plan now sends Swift code that touches private user data to the full review panel (GST-3052). (#4472) - A round grant at /ship's review round cap now buys the fix round it names, in the same run or the next (GST-2968). (#4479) - The secrets check stops flagging three kinds of ordinary code as a secret, and catches two misses. (#4457) - A security finding's location and reason no longer go into a PR body. (#4486) - The token-capped /ship child on Claude Code now starts its prompt with the typed `/ship` command, so the skill actually loads. (#4487) - A /ship receipt now counts the second-model review's blocking findings, and refuses to be written while one is still open. (#4485) - A `/ship` with a token cap on Claude Code no longer stops at its first handoff. (#4452) - /ship's push step now always ends with one line that says whether it pushed (GST-3053). (#4474) - A PR's review-round count can no longer be overwritten by the body `/ship` posts. (#4440) - One queued record with a malformed path no longer stops artifacts sync for every project. (#4455) - A failed artifacts push stays reported until a push succeeds. (#4455) - The /sync-gbrain memory row no longer says OK when pages failed to import. (#4455) - ### Tests (#4495) - A policy-floor test no longer fails once gstack's own version reaches the minor after the newest policy key; it now checks a floor above both, so the v1.101.0.0 release can pass CI. (#4495) - CI now uploads free-suite test results to Trunk with analytics-uploader v2.1.8 and analytics-cli 0.17.0, up from v2.1.6 and 0.16.2. (#4453) - Packing a checkout for a Ubicloud run no longer fails when git beside it is rewriting a ref. (#4447) - The /plan-ceo-review HOLD SCOPE eval no longer fails a review because its follow-up question didn't repeat the mode name. (#4447) - Unattended /autoplan now records the owner's relayed gate reply instead of refusing it. (#4484) - Unattended /autoplan now runs the second-model review you turned on, and waits for it instead of ending the session. (#4459) - Two /autoplan runs started in the same second no longer share a run id. (#4459) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the locked plan for a paid trial: does /ship cost less and catch as much when the pull request's own thread runs it, instead of a separate subagent?
Why: that subagent's own steps cost about $22 of a $35 /ship run, and the keep-or-drop decision is written down here before anything is spent.
Nothing to do: no code changes; paid runs start only after this merges and the budget is approved.
What changed
Catch rule (b) now credits a fix only when the sealed regression test passes, so a reworded but unfixed bug earns nothing.
Before/after as text: Catch rule (b) now credits a fix only when the sealed regression test passes, so a reworded but unfixed bug earns nothing
Today every /ship run on Capy starts a separate subagent just to drive /ship's phases, and a profile of 12 runs put that subagent's own steps at most of the run's cost. This plan fixes, before any money is spent, how we will test dropping it. It uses three arms on the same 10 real gstack pull requests (today's /ship, /ship run by the thread itself, and the same model with no gstack and a plain review prompt), 3 trials each, paired comparisons with 95% intervals, the decision for every outcome, and stop rules under a $3,250 cap. Review caught one real hole before freeze, because a reworded but unfixed planted bug could have counted as fixed. The scoring rule now requires the sealed regression test to pass.
Why
"Does /ship need its conductor subagent?" (GST-3003). Writing the bars, arms and decisions down first means the result decides the question instead of being read to fit it.
Blast radius
One new Markdown file under docs/evals/ and one changelog fragment; no code, prompt or skill changes.
gstack-docs-onlyclasses the file as pinned results, so the full CI suites still run (script ran:DOCS_ONLY: no … pinned results), andgstack-eval-plan prereg --checkprintsPREREG: ok present=8/8.Pre-Landing Review
Light review (docs class, 0 runtime lines). Pass 1: my checklist read plus a second-model review (GPT-6.1 Sol), which both found the same problem: catch rule (b) credited a reworded but unfixed planted bug, contradicting the cosmetic-edit decoy. The plan's author accepted it and the rule was amended (commit 70933db). Pass 2 checked the fix with a fresh reviewer and a red-team reader, and found nothing blocking. Six notes below the floor stay open for the author: the label file should list the sealed regression test so its posted hash covers it; real problems have no sealed test, so say they are scored by clause (a) only; no decoy exercises clause (b)'s credit path (add a test-passes decoy and require the runner to prove the test ran); and a source fix's own test may still sit in the arm's checkout.
Review notes
Below the blocking floor (advisory, informational, test-gap or wording items); recorded here and not fixed in this PR.
docs/evals/ship-conductor-fold-prereg.md:95red-teamdocs/evals/ship-conductor-fold-prereg.md:127red-teamdocs/evals/ship-conductor-fold-prereg.md:140red-teamdocs/evals/ship-conductor-fold-prereg.md:96fix reviewdocs/evals/ship-conductor-fold-prereg.md:140fix reviewdocs/evals/ship-conductor-fold-prereg.md:120fix reviewExploratory QA
Functional smoke, 4 probes, verdict pass:
gstack-eval-plan prereg --check(PREREG: ok),gstack-docs-only --base origin/main(DOCS_ONLY: no, pinned results), and the repository references the plan relies on (commit 0ee5914, ship/DRIVER.md, bin/gstack-ship-phase, eval-plan judge and results checks, voice-models.json as a per-pass file from lib/review-pass.ts) all resolve.Design Review
No frontend files changed — design review skipped.
Eval Results
No prompt-related files changed — evals skipped.
Scope Drift
Scope Check: CLEAN
Verification Results
No plan file; no plan-specific verification items. Automatic QA above.
TODOS
No TODO items completed in this PR.
Documentation
Status: current. No documentation changes were needed.
Scope: base 0ee5914 to head 70933db on capy/plan-a-trial-of. The selected content is the committed
docs/evals/ship-conductor-fold-prereg.mdand the untrackedchangelog.d/capy-plan-a-trial-of.md. Nothing is staged or unstaged. The audit read both files in full, checked their cross-references indocs/inventory.mdanddocs/review-policy.md, and checked the commands and markers the prereg names againstbin/gstack-ship-phase,lib/ship-clock.ts,lib/ship-budget-cli.ts,lib/ship-call-log.tsandlib/review-pass.ts.Documentation health:
docs/evals/ship-conductor-fold-prereg.md: Current. It is new, and its factual claims match the code at the base commit.changelog.d/capy-plan-a-trial-of.md: Current. It was reviewed only, because the parent owns changelog writes.Coverage debt: none. The change is a preregistration with no shipped behavior to document. The results doc it names,
docs/evals/ship-conductor-fold-results.md, is expected only after the paid run. No diagrams are affected.Tests
bun run test): carried from CI run 44137100344 at 80e9f70, 37,510 tests in 1,681 files, 0 failAgent notes
Refs GST-3003
Approvals
No approvals recorded for branch capy/plan-a-trial-of.
Plan: required
Plan check: PLAN_NOT_APPROVED (gstack-approvals plan-check says why)
Gate edits: none detected (0 listed, 0 read; patterns: RH-1,RH-3,RH-4,RH-12,RH-13,RH-14,RH-15,RH-16; unlisted idioms: none)
Outside review: openai/gpt-6.1-sol (host subagent), completed, 1 finding (fixed)