Merged
Conversation
Rangi42
requested changes
Dec 31, 2025
Collaborator
Rangi42
left a comment
Rangi42
left a comment
There was a problem hiding this comment.
Interesting, thanks for this! It would be great for the Pan Docs to cover these registers as well. (https://gbdev.io/pandocs/CGB_Registers.html#undocumented-registers is very sparse and doesn't mention $FF71.)
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Co-authored-by: Rangi <35663410+Rangi42@users.noreply.github.com>
Member
Author
Thanks for reviewing. Yes, I hope to get on to updating the Pan Docs next. I also have a test ROM to release that verifies the register behaviour. |
avivace
approved these changes
Dec 31, 2025
ISSOtm
approved these changes
Dec 31, 2025
Member
ISSOtm
left a comment
ISSOtm
left a comment
There was a problem hiding this comment.
Yeah, looks good to me. Thank you!
Rangi42
approved these changes
Jan 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm planning to release the source code for apparently.gb and so thought it would be nice to add these registers and constants for the PSW related registers.